From owner-svn-ports-all@freebsd.org Sat Dec 17 15:35:49 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8688CC857BD; Sat, 17 Dec 2016 15:35:49 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com [IPv6:2a00:1450:4010:c07::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 271B6DA4; Sat, 17 Dec 2016 15:35:49 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: by mail-lf0-x244.google.com with SMTP id y21so3782617lfa.0; Sat, 17 Dec 2016 07:35:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=zLlxasFutPYMsdQGNjXmxANS/My2hvTn3/WhVN1OeWk=; b=sQm4a3am6rMdYjLJsPo6ABvX1c+cXlNrYHB5XjTvG5+TaI71sMWzzfe8R8ndnT4SXs yPZmDlL94ylfJUi/ZTPwIXKWljDA+V7ggM15rokFooUUzOsujqoEVDpYQhhIKrsPaTYm VnEMYMhs950nllzjxlfbiRn23wwTyTpvlTDwR44XpxT1Yvf32TISfBypR0xnoGgHQohM jQH8KDwdi99JJhq0sh7C/mMXR55DcZXqmN3AFFXrMXin3p3itlLOsmb3QTvzut1X1KfG 0eE1mJaxmpObxlPjXmROgCQS9AnXTrS59PaMp7mnM7DsicFnE/wGm5ZezRI74HGcX4h5 P0lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zLlxasFutPYMsdQGNjXmxANS/My2hvTn3/WhVN1OeWk=; b=nFAW1AduSwloQqvAtt2WWm5ew5EcwN46a065Ce9N8qYkTzFO8Hs7w/gM+oog6iUq/1 s9aeKRkM9jqQZACAwBbaICA/luwRbbphz2xAhinUsvHqYDFr3GczTZXCU3e5eNwpV2k7 3j+NCu9GLobUAzkuBFFrPvVKAftXUrsEox4TBMlRDypLjV8XqDWjq7eoNZMBgVJI4ui7 MI3zCxtGzhciOSH6cUHPKe5xuR1CIqL3BgiwKgEWlTEEz4HO5UvLRS3n6a/HnTtkaJH9 DAFY6mkUcBOIWxkJ8DuucVrIHmZR/BmifrstjO2YNRyo2c0Rx9PDXlIjdE88csqvP8Hi 1PJQ== X-Gm-Message-State: AIkVDXIH2ZBmpn6T+aRzEQITPsdVe/D+69wh1HuYaQE2tETR7+uTUXxOISyNZQhrLcxswJfL/ndrhkGVZQDNTA== X-Received: by 10.25.24.160 with SMTP id 32mr1364670lfy.103.1481988946961; Sat, 17 Dec 2016 07:35:46 -0800 (PST) MIME-Version: 1.0 Sender: bsdkaffee@gmail.com Received: by 10.25.228.196 with HTTP; Sat, 17 Dec 2016 07:35:46 -0800 (PST) In-Reply-To: <8660miveyx.fsf@FreeBSD.org> References: <201612161531.uBGFVOI4055900@repo.freebsd.org> <8660miveyx.fsf@FreeBSD.org> From: "Jason E. Hale" Date: Sat, 17 Dec 2016 10:35:46 -0500 X-Google-Sender-Auth: Ex60X84umVO7ZwjbepXVVeSsNZs Message-ID: Subject: Re: svn commit: r428683 - in head/security: pinentry pinentry-qt4 pinentry/files To: Raphael Kubo da Costa Cc: ports-committers , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2016 15:35:49 -0000 On Sat, Dec 17, 2016 at 8:53 AM, Raphael Kubo da Costa wrote: > "Jason E. Hale" writes: > >> Author: jhale >> Date: Fri Dec 16 15:31:24 2016 >> New Revision: 428683 >> URL: https://svnweb.freebsd.org/changeset/ports/428683 >> >> Log: >> Update to 1.0.0 >> Add LICENSE (GPLv2+) >> Dependency cleanup >> Whitespace fix >> Remake patches >> Take maintainership > > This broke pinentry-qt5: > > checking for Qt5Core >= 5.0.0 Qt5Gui >= 5.0.0 Qt5Widgets >= 5.0.0... yes > checking for Qt5Core >= 5.7.0... no > checking for moc... /usr/local/lib/qt5/bin/moc > checking moc version... no > checking for moc-qt5... no > checking for qtchooser... no > ./configure: qtchooser: not found > checking for QtCore >= 4.6.0 QtGui >= 4.6.0... yes > checking for moc... (cached) /usr/local/lib/qt5/bin/moc > checking moc version... no > checking for moc-qt4... no > configure: error: No pinentry enabled. Hmm, I ran all the flavors through poudriere before the commit and never ran across this and I can't reproduce it. It looks like the configure script has the correct moc, but the moc version detection is failing. The version detection scheme is exactly the same in the qt.m4 file as the previous version, so why it's only not working with this version is beyond me. The only thing they changed in that file was requiring c++11 for Qt >= 5.7.0 which wouldn't apply here. AC_CHECK_TOOL(MOC, moc) AC_MSG_CHECKING([moc version]) mocversion=`$MOC -v 2>&1` mocversiongrep=`echo $mocversion | grep "Qt 5\|moc 5"` if test x"$mocversiongrep" != x"$mocversion"; then AC_MSG_RESULT([no]) $ /usr/local/lib/qt5/bin/moc -v moc 5.6.2 Which satisfies the condition, unless your 'moc -v' is barfing out something strange.