From owner-svn-ports-head@freebsd.org Sat Nov 23 15:30:54 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D8B241B857B; Sat, 23 Nov 2019 15:30:54 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from lb2-smtp-cloud7.xs4all.net (lb2-smtp-cloud7.xs4all.net [194.109.24.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.xs4all.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Ky1V37Xgz4BHW; Sat, 23 Nov 2019 15:30:54 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from reneon.localnet ([IPv6:2001:985:ab38:1:21f:c6ff:feba:d9]) by smtp-cloud7.xs4all.net with ESMTP id YXN4ilRHCcs92YXN5iKOXM; Sat, 23 Nov 2019 16:30:52 +0100 From: Adriaan de Groot To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r518243 - head/x11-toolkits/qt5-gui Date: Sat, 23 Nov 2019 16:30:45 +0100 Message-ID: <8680887.Jb6mJC18hs@reneon> Organization: FreeBSD In-Reply-To: <20191123145524.GA84936@FreeBSD.org> References: <201911231446.xANEkdSZ075924@repo.freebsd.org> <20191123145524.GA84936@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1695823.fVUeUJyjye"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-CMAE-Envelope: MS4wfM7C+kn0oJVNAHJNxqTO+Y4wjyL7kyucRhkWsnIw7LZVzJXPCP9LDTxVnDEA5HUu/jE08zeZFJDKwylUJk8n51qZyzUZdnzmwG42L5OgIScTaS5//S7t qGUcimCgYt1V2kpXF/K4B0IbdMbvA+4j0QYXDSwwpQjgBGMA0ZEGhZIEX3utw2td7MqUpql5bfECCm1NBjwduKmCkLtGSq/+7j26CAe7AQOYu3zWMJ82jair awbz8Ovqc6yPqUWFfjYm1kKiUqNOLE4WWSpiXD7pdSwY8i3Oyta26VWo7w+Zg2ClzElu2wyMronT7/o3vzOaDES16AnTvOqYeddGNIz+2Ac= X-Rspamd-Queue-Id: 47Ky1V37Xgz4BHW X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.95 / 15.00]; NEURAL_HAM_MEDIUM(-0.98)[-0.976,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-0.98)[-0.977,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Nov 2019 15:30:54 -0000 --nextPart1695823.fVUeUJyjye Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Saturday, November 23, 2019 3:55:24 PM CET Alexey Dokuchaev wrote: > > +RUN_DEPENDS= xdg-open:devel/xdg-utils \ > > + ${LOCALBASE}/include/vulkan/vulkan.h:devel/vulkan-headers > > Commit log does not really explain how come a *header file* is needed > at runtime. If the problem is with `sysutils/qt5-qtdiag', shouldn't it > be fixed instead? Every consumer of qt5-gui would (potentially) need a BUILD_DEPENDS on vulkan headers. This seemed easier. Possibly RUN_DEPENDS is a bad choice; I'd put this in LIB_DEPENDS except that it's a headers-only dependency. > Also, previously when Vulkan headers were only a bdep I didn't raise > the question about why it was not made OPTIONal, but I do now. There > are plenty of Qt5 users who would likely never want to have any Vulkan > bits on their systems. Since this is a headers-only dependency which is only a few kB in size, we (kde@) decided to just install it rather than mess around with trying to make it OPTIONAL. [ade] --nextPart1695823.fVUeUJyjye Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEUq+pvuD+N8/vVW++WoDe9T7W/7IFAl3ZUKUACgkQWoDe9T7W /7I7Gg//b2P2DK3o0haiPJX1tOwX4SqIdAOoh9sqy+vkX05G5iLbgWJbzWTF5aRV z0iJel2xnQMjCf+xz+NpbyMBoY0Z21mRQ4GSIyjHrowjKy2+wCNBxg/RQRUjQAY8 KDA9FZH1iB8kwGuYkSFYS7EiqlKLW6vlTFiaj81yKZIkKKTbN1/865donvg8Tshk nvRTd2vkeMiqY3UDsf2eE/5cBYWJBbd5R/PETjE/3mWDEgqTruG2n9pmq038oKDi un5igDpWdWSnPWmleth8fMFUMAFn8xet0ClIjdKR7VrcQMf3XqOmXz4UabPnVohK XiMyO7Qq1/U0u6obUjXlZ+s++k2fYDbuTwNbZApR/9mX/x3jhxbcPSCfrO9bjrVJ zy8jP0jokeAiy5Pvoc5btkopGvUmAkWA6DCqRrPHKDCzFuQZRNMIMf64OWKMX2Au 22rmhUP0kywoXncJfyllmMl2vy+0IZOYfC8U37ru6rBhV0dT6/ke/dAeQjYQPcBG hGweU3BKWywdlyA0JcysiPmUcqxs8NbBv2X3aX7yGmCRh6OARzUZFaMEqX8JIFjm LRF9CsQ9db+dZyxKVaf7Jgd3mycei54xNg7m90k1t+TYFISHON+BfyE9nGepLymg GdP0qQCGwL7TrprSnyzqAEEYE+5vRfC+yJeP0Q1YjAj0uz3DbHQ= =6+FB -----END PGP SIGNATURE----- --nextPart1695823.fVUeUJyjye--