From owner-svn-src-all@freebsd.org  Fri Mar 16 17:29:23 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAC0FF5FF74;
 Fri, 16 Mar 2018 17:29:23 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au
 [211.29.132.246])
 by mx1.freebsd.org (Postfix) with ESMTP id 396FA6AB83;
 Fri, 16 Mar 2018 17:29:22 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au
 [110.21.101.228])
 by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 0D32942D1F1;
 Sat, 17 Mar 2018 04:29:21 +1100 (AEDT)
Date: Sat, 17 Mar 2018 04:29:20 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Ian Lepore <ian@freebsd.org>
cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Subject: Re: svn commit: r331063 - head/sys/arm/arm
In-Reply-To: <201803161606.w2GG6QCJ091704@repo.freebsd.org>
Message-ID: <20180317041629.Y23257@besplex.bde.org>
References: <201803161606.w2GG6QCJ091704@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.2 cv=FNpr/6gs c=1 sm=1 tr=0
 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17
 a=kj9zAlcOel0A:10 a=s2U_WbHignoRvRs-tPAA:9 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Mar 2018 17:29:23 -0000

On Fri, 16 Mar 2018, Ian Lepore wrote:

> Log:
>  Add the header file needed for the recently-added call to pagedaemon_wakeup().
>
> Modified:
>  head/sys/arm/arm/pmap-v4.c
>
> Modified: head/sys/arm/arm/pmap-v4.c
> ==============================================================================
> --- head/sys/arm/arm/pmap-v4.c	Fri Mar 16 16:04:06 2018	(r331062)
> +++ head/sys/arm/arm/pmap-v4.c	Fri Mar 16 16:06:25 2018	(r331063)
> @@ -168,6 +168,7 @@ __FBSDID("$FreeBSD$");
> #include <vm/vm_page.h>
> #include <vm/vm_pageout.h>
> #include <vm/vm_phys.h>
> +#include <vm/vm_pagequeue.h>
> #include <vm/vm_extern.h>
>
> #include <machine/md_var.h>

It used to be in the correct header (vm/vm_pageout.h).

Another bug in this function is its name.  It is missing a vm_ prefix.
It was the only name in vm_pageout.h with this bug (macros there have
a prefix of VM_; variables and functions have a prefix of vm_).

vm_pagequeue.h was almost as clean.  It is now polluted by:
- nested include of sys/pidcontrol.h
- prototype for this function
- call to this function.

Bruce