From owner-freebsd-acpi@FreeBSD.ORG Thu Sep 6 03:51:58 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E9EF1106564A; Thu, 6 Sep 2012 03:51:58 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 52E498FC15; Thu, 6 Sep 2012 03:51:58 +0000 (UTC) Received: by weyx56 with SMTP id x56so1009466wey.13 for ; Wed, 05 Sep 2012 20:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=rdWly/3vQ/ZBQn1jXHBHeH+NyfuGEBxjXBP/LJIYV1E=; b=d85Z2ilS/OkYp1U4yEq5fkJb/2WKY3RqPQajl3IQkke5L8MsTM5rq/0HrWjKilFuGM EwpjZ5iKwn5ksSK0Is4IcpkxVa5AztlyllljJPSUa+rloVWGo4OHFCV0Z3XLqO+kuZwA V9H6FcTrJu0i3Fy5fM+FrC48Y8x5RcIoQNC2s5HsPceAppv9DzQJwt/L3mTwR+Rmsrm/ f3ra8Mr1Hz4mZnI66g2seZhyN+BQrioQSNta8jZm0mq4KINEZFNmz+/WZJUF5yRnB7oK X8/+fnyMZtvJTh+jq8DLQAvypstxXrad8nw2bcBFwlQu+Aw2lv4ZTglvFesJng+SLOzU epmA== MIME-Version: 1.0 Received: by 10.180.107.103 with SMTP id hb7mr1772031wib.3.1346903517302; Wed, 05 Sep 2012 20:51:57 -0700 (PDT) Received: by 10.223.63.76 with HTTP; Wed, 5 Sep 2012 20:51:57 -0700 (PDT) In-Reply-To: <5047B7E7.5080802@FreeBSD.org> References: <4FF95F79.30309@FreeBSD.org> <1341935370.4493.4.camel@powernoodle> <4FFFD891.2060109@FreeBSD.org> <5046F105.80706@FreeBSD.org> <504779D8.4030909@FreeBSD.org> <50477E9F.7030604@FreeBSD.org> <5047B7E7.5080802@FreeBSD.org> Date: Wed, 5 Sep 2012 20:51:57 -0700 Message-ID: From: Kevin Oberman To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Cc: freebsd-acpi@freebsd.org Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2012 03:51:59 -0000 On Wed, Sep 5, 2012 at 1:36 PM, Andriy Gapon wrote: > on 05/09/2012 20:41 Kevin Oberman said the following: >> On Wed, Sep 5, 2012 at 9:32 AM, Andriy Gapon wrote: >>> on 05/09/2012 19:23 Kevin Oberman said the following: >>>> On Wed, Sep 5, 2012 at 9:12 AM, Andriy Gapon wrote: >>>>> on 05/09/2012 18:17 Kevin Oberman said the following: >>>>>> Thanks so much! This should finally make Cx states work on my >>>>>> ThinkPad! I really appreciate it. Guess it's time to do my weekly >>>>>> upgrade of this system. >>>>> >>>>> I haven't sneaked in that other commit :-( >>>> >>>> Oops! :-( >>>> >>>> Oh, well. At least it should make it to /base/stable/9 soon. Right??? >>>> (I only run release/ or releng/ or for an occasional test.) >>>> >>> >>> It's already in stable/9 :) >> >> Ahh! I now see C3/109, but I see some strange behavior. When on AC >> power, only C1/1 and C2/104 are available, but cx_lowest is C3, even >> though C3 is not available. If I switch to battery, C1/1, C2/80 and >> C3/109 are available (???), but cx_lowest is set to C2. I find the Cx >> value sets a bit odd, but the setting of cx_lowest appears to be a >> bug, at least to me. I can manually set cx_lowest to C3 and I actually >> use C3. >> >> My suspicion is that there is either a race or a logic issue where >> x_lowest is reset to the lowest value before the available Cx values >> are set, so cx_lowest is always set the the lowest Cx state from the >> previous power configuration. (This is a guess, but it fits what I am >> seeing very well.) >> > > Hmm, this looks like the older behavior. > What revision are you at? Also, any local ACPI-related patches? > > -- > Andriy Gapon I'm at R239879, exactly a week ago. Do you have the rev of the commit? I probably just missed it. -- R. Kevin Oberman, Network Engineer E-mail: kob6558@gmail.com