Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Oct 2012 22:23:56 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        "Jason E. Hale" <jhale@FreeBSD.org>
Cc:        svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org, Pawel Pekala <pawel@FreeBSD.org>
Subject:   Re: svn commit: r306571 - head/sysutils/mbmon
Message-ID:  <20121028212355.GV18995@ithaqua.etoilebsd.net>
In-Reply-To: <1663223.kWmZmHxpKG@mocha.verizon.net>
References:  <201210282046.q9SKk6qR095693@svn.freebsd.org> <1663223.kWmZmHxpKG@mocha.verizon.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--ZUxj+kVYsk1YKJSS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 28, 2012 at 05:12:16PM -0400, Jason E. Hale wrote:
> On Sunday, October 28, 2012 20:46:06 Pawel Pekala wrote:
> > Author: pawel
> > Date: Sun Oct 28 20:46:06 2012
> > New Revision: 306571
> > URL: http://svn.freebsd.org/changeset/ports/306571
> >=20
> > Log:
> >   - Convert to OptionsNG [1]
> <--snip-->
> >=20
> > -OPTIONS=3D	SMB "enable smb(4) support" on
> > +OPTIONS_DEFINE=3D	ASUS SMB
> > +OPTIONS_SET=3D	SMB
> > +ASUS_DESC=3D	"Enable A7N8X-VM support"
> > +SMB_DESC=3D	"Enable smb(4) support"
> >=20
> Should be OPTIONS_DEFAULT rather than OPTIONS_SET.
>=20
> --=20
> Jason E. Hale - jhale@
> FreeBSD Ports Committer
> KDE/FreeBSD Team

OPTIONS_SET and OPTIONS_UNSET are for end user, so yes it should be
OPTIONS_DEFAULT here :)

regards,
Bapt

--ZUxj+kVYsk1YKJSS
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlCNomsACgkQ8kTtMUmk6EyxKwCgjBzFE5/0IheN8/C80zg6x83S
1U8AoKotgJVt3g43M/rUcOS2/CO/HWsZ
=zO8T
-----END PGP SIGNATURE-----

--ZUxj+kVYsk1YKJSS--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121028212355.GV18995>