From owner-svn-src-all@freebsd.org  Sun Dec 27 18:41:11 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39A0AA5287F;
 Sun, 27 Dec 2015 18:41:11 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E02631789;
 Sun, 27 Dec 2015 18:41:10 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD))
 (envelope-from <slw@zxy.spb.ru>)
 id 1aDGFZ-000CSU-D0; Sun, 27 Dec 2015 21:41:01 +0300
Date: Sun, 27 Dec 2015 21:41:01 +0300
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: Ian Lepore <ian@freebsd.org>
Cc: Dmitry Chagin <dchagin@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r292777 - in head: lib/libc/sys sys/kern
Message-ID: <20151227184101.GG70867@zxy.spb.ru>
References: <201512271537.tBRFb7nN095297@repo.freebsd.org>
 <1451236237.1369.9.camel@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1451236237.1369.9.camel@freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: slw@zxy.spb.ru
X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Dec 2015 18:41:11 -0000

On Sun, Dec 27, 2015 at 10:10:37AM -0700, Ian Lepore wrote:

> On Sun, 2015-12-27 at 15:37 +0000, Dmitry Chagin wrote:
> > Author: dchagin
> > Date: Sun Dec 27 15:37:07 2015
> > New Revision: 292777
> > URL: https://svnweb.freebsd.org/changeset/base/292777
> > 
> > Log:
> >   Verify that tv_sec value specified in settimeofday() and
> > clock_settime()
> >   (CLOCK_REALTIME case) system calls is non negative.
> >   This commit hides a kernel panic in atrtc_settime() as the
> > clock_ts_to_ct()
> >   does not properly convert negative tv_sec.
> >   
> >   ps. in my opinion clock_ts_to_ct() should be rewritten to properly
> > handle
> >   negative tv_sec values.
> >   
> >   Differential Revision:	https://reviews.freebsd.org/D4714
> >   Reviewed by:		kib
> >   
> >   MFC after:	1 week
> 
> IMO, this change is completely unacceptable.  If there is a bug in
> atrtc code, then by all means fix it, but preventing anyone from
> setting valid time values on the system because one driver's code can't
> handle it is just wrong.

You talk about kernel panic when internal data structures not
destructed is normal behavior? Realy?