From owner-cvs-all Mon Sep 24 13: 5:35 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id CCEC237B418; Mon, 24 Sep 2001 13:05:19 -0700 (PDT) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id f8OK5J025521; Mon, 24 Sep 2001 13:05:19 -0700 (PDT) (envelope-from obrien) Date: Mon, 24 Sep 2001 13:05:19 -0700 From: "David O'Brien" To: John Baldwin Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/conf GENERIC src/sys/i386/conf GEN Message-ID: <20010924130519.A25323@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200109240323.f8O3Nmf69956@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Mon, Sep 24, 2001 at 12:33:49PM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Sep 24, 2001 at 12:33:49PM -0700, John Baldwin wrote: > > obrien 2001/09/23 20:23:48 PDT > > Modified files: > > sys/alpha/conf GENERIC > > sys/i386/conf GENERIC > > sys/ia64/conf GENERIC > > sys/pc98/conf GENERIC > > sys/sparc64/conf GENERIC > > Log: > > + Fix misplacement of `txp' > > + Document our -CURRENT debugging bits > > 1) The comments wrap beyongd 80 cols which is not very aesthetic :) I know. I could not figure out how to make them shorter w/o them loosing content. Suggestions desired. > They also don't have a space after the # character. Nor does the options from INET thru P1003_1B -- I was just following the style I saw. > 2) INVARIANT_SUPPORT does not enable any extra checks, it just provides > support code that sanity checks may call (such as the _mtx_assert() > function that backs mtx_assert()). I didn't use the word "enable" for INVARIANT_SUPPORT, only INVARIANT. :-) > 3) WITNESS is not mutex checks, it is checks for locks in general. It's true > that lockmgr doesn't yet call witness, but that might be done in the > future, and sx locks already use WITNESS as well. From NOTES: # WITNESS enables the mutex witness code which detects deadlocks and # cycles during locking operations. Perhaps you could clarify the comment there? > 4) Witness does not detect deadlocks. See the extract of NOTES above. :=) Diffs to my commit to better clarify things would gladly be accepted. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message