From owner-cvs-all@FreeBSD.ORG Sun May 15 06:38:57 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02E5D106566C; Sun, 15 May 2011 06:38:57 +0000 (UTC) (envelope-from jnlinn@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id D21438FC0A; Sun, 15 May 2011 06:38:55 +0000 (UTC) Received: by wwc33 with SMTP id 33so3956226wwc.31 for ; Sat, 14 May 2011 23:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LgnBpKImmP18TPAXCgNfu+IJXcX9vS+s3DFGRZSjKBA=; b=mR4O5DzVmweYNMH6fho7lkDwMPyyZ1buw7WSUfspk0xdyUQUZBC71Y+cD9GxqQsrWi 1QgsRdiY9uc0iynHzHrxmL21rBhSuRa7JUYVVYrVpuI0fwpOHFKWAQeyHps9BQYbDHB+ wmusqLJEKBrdYT7hdsBfcUaiWCUn5oArockzs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=D3J6iIwrd9aCyiGUhEdbwBXSkY9mK1ghvdPVGeyYawhNWpoQKGI9zMXL0Qh1s3nCQ0 Clwk91Vauwq9fIpm0u7Ty1ecilcURR+SP8gBNNT6vnwht1CTdChVwQUhlk2q20CId6H+ CrlXLLQuQW5Y5R26xhXsau7hq8VrBXTooKs4k= MIME-Version: 1.0 Received: by 10.227.204.205 with SMTP id fn13mr3100037wbb.10.1305440093450; Sat, 14 May 2011 23:14:53 -0700 (PDT) Sender: jnlinn@gmail.com Received: by 10.227.72.201 with HTTP; Sat, 14 May 2011 23:14:53 -0700 (PDT) In-Reply-To: <4DCF0192.6030808@FreeBSD.org> References: <201105131353.p4DDrtms046413@repoman.freebsd.org> <4DCF0192.6030808@FreeBSD.org> Date: Sun, 15 May 2011 14:14:53 +0800 X-Google-Sender-Auth: qRyQmECDgIrBJssGn7-OUqKecf4 Message-ID: From: Jui-Nan Lin To: Doug Barton Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Greg Larkin , cvs-ports@freebsd.org, Erik Steigler , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net/scribe Makefile ports/net/scribe/files scribe.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 May 2011 06:38:57 -0000 Hello, This patch does not work on my installation. jnlin@Florence [2:14pm] [W2] ~> sudo /usr/local/etc/rc.d/scribe onestart Starting scribe. jnlin@Florence [2:14pm] [W2] ~> sudo cat /var/run/scribe.pid && echo 38550 jnlin@Florence [2:14pm] [W2] ~> sudo /usr/local/etc/rc.d/scribe onestop scribe not running? (check /var/run/scribe.pid). On Sun, May 15, 2011 at 6:26 AM, Doug Barton wrote: > Adding set_rcvar is the right solution for the problem described in the P= R, > but the other changes are going in the wrong direction. Any time you(pl.) > feel compelled to re-write start_cmd it is almost universally the wrong > answer. > > In the attached patch: > 1. Miscellaneous whitespace fixes (style issue, non-critical) > 2. Change REQUIRE to LOGIN which is what is typically done for local > scripts. If there is some reason that it needs to be run earlier this can= be > omitted. > 3. Add KEYWORD shutdown which should be present for scripts that start a > persistent service so that they can be shutdown cleanly. > 4. Use daemon as the command which is how this is sort of thing is typica= lly > done. > 5. Remove the default-empty _flags assignment (neither necessary or > desirable). > 6. Put the right arguments into command_args to make command=3Ddaemon wor= k > properly. > > Please test these changes. Maintainer can you please respond in a timely > manner? :) > > > Thanks, > > Doug > > > On 05/13/2011 06:53, Greg Larkin wrote: >> >> glarkin =C2=A0 =C2=A0 2011-05-13 13:53:55 UTC >> >> =C2=A0 FreeBSD ports repository >> >> =C2=A0 Modified files: >> =C2=A0 =C2=A0 net/scribe =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Makefile >> =C2=A0 =C2=A0 net/scribe/files =C2=A0 =C2=A0 scribe.in >> =C2=A0 Log: >> =C2=A0 - Fixed rc.d script so it adheres to rc.conf setting [1] >> =C2=A0 - Added missing dependency on devel/py-thrift >> =C2=A0 - Bumped PORTREVISION >> >> =C2=A0 PR: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ports/154942 (based= on) >> =C2=A0http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D154942 >> =C2=A0 Submitted by: =C2=A0 Erik Steigler =C2=A0[1] >> =C2=A0 Approved by: =C2=A0 =C2=A0maintainer timeout (18 days) >> >> =C2=A0 Revision =C2=A0Changes =C2=A0 =C2=A0Path >> =C2=A0 1.6 =C2=A0 =C2=A0 =C2=A0 +4 -2 =C2=A0 =C2=A0 =C2=A0ports/net/scri= be/Makefile >> =C2=A0 1.2 =C2=A0 =C2=A0 =C2=A0 +16 -3 =C2=A0 =C2=A0 ports/net/scribe/fi= les/scribe.in >> >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/scribe/Makefile.diff?&r1= =3D1.5&r2=3D1.6&f=3Dh >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/scribe/files/scribe.in.d= iff?&r1=3D1.1&r2=3D1.2&f=3Dh >> > > > > -- > > =C2=A0 =C2=A0 =C2=A0 =C2=A0Nothin' ever doesn't change, but nothin' chang= es much. > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0-- OK Go > > =C2=A0 =C2=A0 =C2=A0 =C2=A0Breadth of IT experience, and depth of knowled= ge in the DNS. > =C2=A0 =C2=A0 =C2=A0 =C2=A0Yours for the right price. =C2=A0:) =C2=A0http= ://SupersetSolutions.com/ > >