From owner-svn-src-head@freebsd.org Fri May 25 20:11:42 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 449BCEF3283; Fri, 25 May 2018 20:11:42 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-wr0-x234.google.com (mail-wr0-x234.google.com [IPv6:2a00:1450:400c:c0c::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AFD47722EE; Fri, 25 May 2018 20:11:40 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-wr0-x234.google.com with SMTP id j1-v6so11119030wrm.1; Fri, 25 May 2018 13:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=4sJQe+33lO1zy3ahhUIGjk+fG9PMoIXtofZfa0cCbz8=; b=s3KIE3kKbhISJB+dM2HwD5ZbwOEg5qK7dKv8dNJ97zBsAIKgsMTewHVrwvzTYaJx75 2fiKkjG2f9ghEf+pTAjImixSkE9zh2Qt5g32hf5FgQVRlRpOi0FSPAaXHzjaMafiVvGD ND1dNt++8r+WMD39vVFABh7RCjXMQuLS7EeVv9oRGRiNnvSZaJEfOoaIA7s9jNJFJgZa 3b0zq61yYmU5W4BGYNPuSz5LRuxeE2g4tEwVTUfi23/lHPFm8Bs3sbjaRg4MY1ilBczB CalYmXWl6QwlROTGLTiMnF2F7hJsbdDL9VozrIR0esZTDaoBYTIjz1ugbwb+5tOZTuij zcKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=4sJQe+33lO1zy3ahhUIGjk+fG9PMoIXtofZfa0cCbz8=; b=UtSSFKplFpUzWL8Z+f7hsGVmYd/izGJx5v0FyQPzk5gqtjrp7jixNXtcTu+8mISs7k +Co5cgC+bokG7FgJdRIHFtek2Ob+VeZW1YyuGxDwhTPxpSD/wssK69kahrqke/Fb4CsE ttWBrz5aqDON+HEas8gjBmHf4gBxiAF7x06nvKFBAxUmGZsUUHk16Ef72jf3aTB3MSTj /QK7t5YhGYlhhiXWuAqmQ6opiLycKXXSFpcwGhwGkzHlbLCLGHzUKbf4xM7kE/H3svmQ ILklSe/2R7PVorhcXJuswrFKZSVTTyqcObeHzCRtZ8o46eceG0ac4oIvwJEVi4ZHYgft PiiA== X-Gm-Message-State: ALKqPwevMf3+4LOxYCQHC/4hpt89nhRGD+ETDluxnZCk54JCX3SbXO50 dTyQAmsE/ofMclEksgbZk4YsongzcLxlPRzKKOQ= X-Google-Smtp-Source: ADUXVKJFrMwx4a3BdaXCX0cPVhEtVQCViwA+ars5aDvsLU72DiX73VoWXc/2MAwycQZ6PFu3VMCMQcCAhWRhHzHisBw= X-Received: by 2002:a19:3b0e:: with SMTP id i14-v6mr2297420lfa.48.1527279098747; Fri, 25 May 2018 13:11:38 -0700 (PDT) MIME-Version: 1.0 References: <201805250207.w4P275Pf060725@repo.freebsd.org> <20180525151134.GB99063@spindle.one-eyed-alien.net> <20180525174424.GD99063@spindle.one-eyed-alien.net> <20180525182139.GE99063@spindle.one-eyed-alien.net> In-Reply-To: Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Sat, 26 May 2018 04:11:27 +0800 Message-ID: Subject: Re: svn commit: r334199 - head/usr.sbin/bhyve To: Warner Losh Cc: Ed Maste , Marcelo Araujo , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 20:11:42 -0000 On Sat, May 26, 2018, 4:09 AM Warner Losh wrote: > > > On Fri, May 25, 2018 at 2:02 PM, Ed Maste wrote: > >> On 25 May 2018 at 14:26, Marcelo Araujo wrote: >> > >> >> The fact that we don't do NDEBUG builds normally does not allow us to >> >> ignore that it exists. It's perfectly reasonable for a user to build >> >> with CFLAGS+=NDEBUG. That need to work. If code is going to fail to >> >> handle resource errors with NDEBUG set then it needs something like >> this >> >> at the top of the file: >> > >> > Please document it in some place! >> >> NDEBUG is documented in assert(3). The man page should have more of an >> explanation (and examples) of the possible pitfalls of assert() >> though >> > > NDEBUG has been documented in the assert man page since it entered Unix > via PBW in the 7th Edition Unix from Bell Labs. It's part of the C > standard, as well as many POSIX and SVID docs. > Yes I can read that! Now tell me, do we build FreeBSD without assert? If we do, probably we can't run it without crash! > Warner >