From owner-svn-src-stable@FreeBSD.ORG Thu Apr 30 20:02:12 2015 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4096D96D for ; Thu, 30 Apr 2015 20:02:12 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 023491678 for ; Thu, 30 Apr 2015 20:02:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UK2Bcf096340 for ; Thu, 30 Apr 2015 20:02:11 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t3UK2Bw3096337 for svn-src-stable@freebsd.org; Thu, 30 Apr 2015 20:02:11 GMT (envelope-from bdrewery) Received: (qmail 72482 invoked from network); 30 Apr 2015 15:02:07 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 30 Apr 2015 15:02:07 -0500 Message-ID: <55428A44.3090001@FreeBSD.org> Date: Thu, 30 Apr 2015 15:02:12 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Tijl Coosemans CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r282275 - in stable/10: . bin/csh contrib/smbfs/include/netsmb contrib/smbfs/lib/smb include lib/libarchive lib/libc/iconv lib/libc/locale lib/libiconv_modules/BIG5 lib/libiconv_modules... References: <201504301608.t3UG8mNS004104@svn.freebsd.org> <55427802.80300@FreeBSD.org> <20150430213902.21ee48fc@kalimero.tijl.coosemans.org> In-Reply-To: <20150430213902.21ee48fc@kalimero.tijl.coosemans.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="reh9VbAglqQR7grJ30Ksv6vTtnpaMsMdI" X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 20:02:12 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --reh9VbAglqQR7grJ30Ksv6vTtnpaMsMdI Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/30/2015 2:39 PM, Tijl Coosemans wrote: > On Thu, 30 Apr 2015 13:44:18 -0500 Bryan Drewery = wrote: >> On 4/30/2015 11:08 AM, Tijl Coosemans wrote: >>> Author: tijl >>> Date: Thu Apr 30 16:08:47 2015 >>> New Revision: 282275 >>> URL: https://svnweb.freebsd.org/changeset/base/282275 >>> >>> Log: >>> MFC r275805: >>> =20 >>> Fix incorrect type of "invalids" argument in __iconv() prototype. >>> =20 >>> MFC r281550,281591: >>> =20 >>> Remove the const qualifier from iconv(3) to comply with POSIX: >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.htm= l >>> =20 >>> Adjust all code that calls iconv. >>> =20 >>> PR: 199099 >>> >>> Modified: >>> stable/10/UPDATING >>> stable/10/bin/csh/config.h >>> stable/10/bin/csh/iconv_stub.h >>> stable/10/contrib/smbfs/include/netsmb/smb_lib.h >>> stable/10/contrib/smbfs/lib/smb/nls.c >>> stable/10/contrib/smbfs/lib/smb/print.c >>> stable/10/contrib/smbfs/lib/smb/rq.c >>> stable/10/include/iconv.h >>> stable/10/lib/libarchive/Makefile >>> stable/10/lib/libc/iconv/__iconv.c >>> stable/10/lib/libc/iconv/bsd_iconv.c >>> stable/10/lib/libc/iconv/citrus_iconv.h >>> stable/10/lib/libc/iconv/citrus_iconv_local.h >>> stable/10/lib/libc/iconv/citrus_none.c >>> stable/10/lib/libc/iconv/citrus_stdenc.h >>> stable/10/lib/libc/iconv/citrus_stdenc_local.h >>> stable/10/lib/libc/iconv/citrus_stdenc_template.h >>> stable/10/lib/libc/iconv/iconv-internal.h >>> stable/10/lib/libc/iconv/iconv.3 >>> stable/10/lib/libc/iconv/iconv.c >>> stable/10/lib/libc/iconv/iconv_compat.c >>> stable/10/lib/libc/locale/cXXrtomb_iconv.h >>> stable/10/lib/libc/locale/mbrtocXX_iconv.h >>> stable/10/lib/libiconv_modules/BIG5/citrus_big5.c >>> stable/10/lib/libiconv_modules/DECHanyu/citrus_dechanyu.c >>> stable/10/lib/libiconv_modules/EUC/citrus_euc.c >>> stable/10/lib/libiconv_modules/EUCTW/citrus_euctw.c >>> stable/10/lib/libiconv_modules/GBK2K/citrus_gbk2k.c >>> stable/10/lib/libiconv_modules/HZ/citrus_hz.c >>> stable/10/lib/libiconv_modules/ISO2022/citrus_iso2022.c >>> stable/10/lib/libiconv_modules/JOHAB/citrus_johab.c >>> stable/10/lib/libiconv_modules/MSKanji/citrus_mskanji.c >>> stable/10/lib/libiconv_modules/UES/citrus_ues.c >>> stable/10/lib/libiconv_modules/UTF1632/citrus_utf1632.c >>> stable/10/lib/libiconv_modules/UTF7/citrus_utf7.c >>> stable/10/lib/libiconv_modules/UTF8/citrus_utf8.c >>> stable/10/lib/libiconv_modules/VIQR/citrus_viqr.c >>> stable/10/lib/libiconv_modules/ZW/citrus_zw.c >>> stable/10/lib/libiconv_modules/iconv_none/citrus_iconv_none.c >>> stable/10/lib/libiconv_modules/iconv_std/citrus_iconv_std.c >>> stable/10/lib/libkiconv/xlat16_iconv.c >>> stable/10/sys/sys/param.h >>> stable/10/usr.bin/iconv/iconv.c >>> Directory Properties: >>> stable/10/ (props changed) >>> >>> Modified: stable/10/UPDATING >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- stable/10/UPDATING Thu Apr 30 15:48:48 2015 (r282274) >>> +++ stable/10/UPDATING Thu Apr 30 16:08:47 2015 (r282275) >>> @@ -16,6 +16,10 @@ from older versions of FreeBSD, try WITH >>> stable/10, and then rebuild without this option. The bootstrap proce= ss from >>> older version of current is a bit fragile. >>> =20 >>> +20150430: >>> + The const qualifier has been removed from iconv(3) to comply with >>> + POSIX. The ports tree is aware of this from r384038 onwards. >>> + >> >> Being an ABI change this seems wrong to MFC. Binaries are not only bui= lt >> from Ports. >> >> For a binary built on 10.1 will this change cause any issues? >=20 > Removing const from a function parameter is not an ABI change, so there= > are no issues for binaries. The worst you can run into is a warning/er= ror > from a compiler (when you pass a const char** argument to what is now a= > char** parameter), but this should be trivial to fix. >=20 Thanks. I wasn't quite sure if it was really an ABI issue or just API. --=20 Regards, Bryan Drewery --reh9VbAglqQR7grJ30Ksv6vTtnpaMsMdI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVQopEAAoJEDXXcbtuRpfPq7YIAJqIfB20pRo1n+Miw2oXI/ro N+Urpl22ISQzQuxdjlt/EOvGhhswTJAtlkPgCOHm68PnW8xZUzEmN3NRRlhRqise KSD8DPtOTbJCm6PWz+Og8iCocgwt06HaX++KvEaqLbAymWkVEP/it325W5LX6c1P c8HqRMO+ew07dg8okLpl2/kMmCOM/ZR9D/O0n6DTtp2icdPZWsNN7rQwh7/8AGa3 ZVDJMkhysswDHiCNcUCU1l0ecGa9ZKpbf2xwlqVaDZWqna/FtUX1Tnd415x7Ta4d xXDMD7WgmxEMxxjYp9XnAGOfVr1A+kcy2dZ2uFHCThg1W4G2757knRNEXS32oeM= =anCv -----END PGP SIGNATURE----- --reh9VbAglqQR7grJ30Ksv6vTtnpaMsMdI--