From owner-freebsd-net@freebsd.org  Thu Jan 12 21:45:59 2017
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D531CAD46A
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Thu, 12 Jan 2017 21:45:59 +0000 (UTC)
 (envelope-from matt.joras@gmail.com)
Received: from mail-qt0-x234.google.com (mail-qt0-x234.google.com
 [IPv6:2607:f8b0:400d:c0d::234])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0D92D18B3
 for <freebsd-net@freebsd.org>; Thu, 12 Jan 2017 21:45:59 +0000 (UTC)
 (envelope-from matt.joras@gmail.com)
Received: by mail-qt0-x234.google.com with SMTP id v23so31265033qtb.0
 for <freebsd-net@freebsd.org>; Thu, 12 Jan 2017 13:45:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=x7W1Vet+t4i3VtPFA1LqDAxPwL1tfDIqv7Gkjzc1OPQ=;
 b=KJtPNlvP3Jm5Y8y8HT+rksu/QEuuifakrR8nH/NoOP9DLqamWQak7+yfyI0yjx+a1v
 JdzWQZXv6Xh+02S0Chj3TVLrz0S2AruRY+jWM4jAYM3b90rC7qLG3G865WXTQ3sIqM53
 7/FOjjaLSoH/w3io4YzM3cFMABR36EezPwWS8+IMrIFwGvBNZSEdwXaOzPDgVKS8gD+7
 CPnfiFGu16shMSVEJevw2JO3lPOX5Yq6zJEIOv5HoT0t/q+6lDZgLQdI/lqB8CzfmUGE
 Sok8YXFNI733o1g4R0Wm8vSQNO1AxpYZMVLkLpwZP4wIvaqtfTgCi5jcxG3JKro7or12
 m7og==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=x7W1Vet+t4i3VtPFA1LqDAxPwL1tfDIqv7Gkjzc1OPQ=;
 b=fC8Xvz46gWlNO1JH2DlnxzqSV25r3edHRlTQDuxz1g6t1X4XEkTgR+0nRIhAG5GVBj
 64/aEFMSTPUXJ7Iu65fqGmK6JVg9u790l7ilQyVYQBch72MN1Vb0lX/kjSL2iH3KF8d8
 rEdjxgRRChBVk0dM7mFKrxxwGjY3W/uwqVfRvtxH17LccQCldOlKPjrgA15WLpc1WIDu
 y8JNZTFpHyVkGrCccmkq063xvP1RWiDpuJH2x+QM3KXdtXLGX2WjMqoaHZ19NnWuuJhL
 rG+F8elFoouReJx2pXs9A60Nv5GRBs9ui8WzafxcM7SZT65N+9USdNEH15Pi8KgRgvWS
 3rQw==
X-Gm-Message-State: AIkVDXIKJUo6JILP94yjQ0sRQtdaRgc8Ri7ECcc49WWD16l0F4OZXzrmZ6JvV4g5oNdiWwfw08e0HeK2fZCZvg==
X-Received: by 10.200.40.45 with SMTP id 42mr14206849qtq.89.1484257558157;
 Thu, 12 Jan 2017 13:45:58 -0800 (PST)
MIME-Version: 1.0
Received: by 10.12.175.11 with HTTP; Thu, 12 Jan 2017 13:45:57 -0800 (PST)
From: Matt Joras <matt.joras@gmail.com>
Date: Thu, 12 Jan 2017 13:45:57 -0800
Message-ID: <CADdTf+ggybWCyg3gtMitmqqtBMgKpByHkEarhbWut+ZLF13A-w@mail.gmail.com>
Subject: Fix dangling pointer left by ifmedia_removeall
To: FreeBSD Net <freebsd-net@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2017 21:45:59 -0000

I thought I'd bring this review to people's attention:
https://reviews.freebsd.org/D9164

The problem is fairly straightforward, as is the fix. ixgbe(4) uses
ifmedia_removeall in a way that other drivers do not, which ends up
leaving a dangling pointer in the ifmedia struct leading to incorrect
information displayed by ifconfig(8).

Matt