From owner-freebsd-security  Fri Sep 21 10:45:36 2001
Delivered-To: freebsd-security@freebsd.org
Received: from webs1.accretive-networks.net (webs1.accretive-networks.net [207.246.154.13])
	by hub.freebsd.org (Postfix) with ESMTP id 0841137B406
	for <FreeBSD-Security@FreeBSD.ORG>; Fri, 21 Sep 2001 10:45:32 -0700 (PDT)
Received: from localhost (davidk@localhost)
	by webs1.accretive-networks.net (8.11.1/8.11.3) with ESMTP id f8LGed835614;
	Fri, 21 Sep 2001 09:40:39 -0700 (PDT)
Date: Fri, 21 Sep 2001 09:40:39 -0700 (PDT)
From: David Kirchner <davidk@accretivetg.com>
X-X-Sender:  <davidk@localhost>
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc: Marc Rogers <marcr@shady.org>, Peter Pentchev <roam@ringlet.net>,
	Rob Andrews <rob@cyberpunkz.org>, <FreeBSD-Security@FreeBSD.ORG>
Subject: Re: login_conf vulnerability.
In-Reply-To: <20010921173502.A62350@nagual.pp.ru>
Message-ID: <20010921093907.C85958-100000@localhost>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-security@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-security.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-security>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-security>
X-Loop: FreeBSD.org

On Fri, 21 Sep 2001, Andrey A. Chernov wrote:

> It is SSH+LOGIN_CAP integration bug. SSH should call setusercontext()
> before accessing "copyright" and "welcome" properties, as /usr/bin/login
> does.

This is from 4.2R source. Would this be the location to patch?

Line 967 session.c:

                if (setusercontext(lc, pw, pw->pw_uid, LOGIN_SETALL) < 0)

would that be replaced with how it is in login:

                if (setusercontext(lc, pw, pw->pw_uid, \
			LOGIN_SETALL & ~LOGIN_SETLOGIN) < 0)

?


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message