From owner-svn-src-head@freebsd.org Fri Aug 17 17:06:29 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 006711075B2D for ; Fri, 17 Aug 2018 17:06:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 87AF08A2DD for ; Fri, 17 Aug 2018 17:06:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x234.google.com with SMTP id 139-v6so12637415itf.0 for ; Fri, 17 Aug 2018 10:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=2qPP0Q3iCRZmT467+2Lpw+NjrxawjrKpaUM/xMOAsdA=; b=g0y2go0xCqJN+No5lhYj+K+IEdc8uPJciLUy4v9n2txSeeigz7ndY8mnqHLHL7CCJf p7Mq66mjPyWbCRMG2DIfhZBxTY0Qeqip0YEUqH278Qo92byvPOyUu5c8sMKdlom8ecUC gqYDTsPMX3Zi9inCz50zR5ZX0Hqe4uwJJubDEBkzQSm+mRZG1nuPNoy6rXJCzG8eMtXl R0irRlnPWU29yMcOK2JnJF2qL3bSWFthgyYsZP0axXGDLDrYEX3Wyr8Ydnzql1p0iG3N l45Ho/1mKfk6A4GiOyq6a03aaukRnBowWSnSD3pQwRHJeJAbcbStXtbs61JTquyojMoc jLcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=2qPP0Q3iCRZmT467+2Lpw+NjrxawjrKpaUM/xMOAsdA=; b=KYgaC+755DIPYZhrz+0HCmgbnUwHj6HDCGhRfD6QR+JLGkSK/7k4mUchDGuhBEYwOB FfeLVm1za4RY+qPC5vKRKpV2WechVODCmsEYsQulB7zepGhmQgU1HKMlou7wr2+s2WqO hlMgZI+olQTKVIfGRhRHwTpNAtKyVCDk5WTiWtZnlJuJ9E10E8hpJCsX214Xkl6b0Gvw HktXPGbuvMLCdLuOcYt+RLKnkNovSHb0/tvymtnv1ojXhUAfYSN9ji9zcXEPm6Vr+CUZ QUfvvFmR7IILxo5hyBm80E1I7MAw2L135Z9QgFudgCSAc0e2qbLF4Zjm5PrwswIldJ6W u4RQ== X-Gm-Message-State: AOUpUlHjyAnl3T3wiPi6JvLoTuviVUj0g+GmfBfnLHiOEHj83iAR8kMe sx8k7RGT8FlyUC85A0ymETNto0D5B/oaxW1/NYKpAQ== X-Google-Smtp-Source: AA+uWPxkqF06sxy4j8J62KokTE73DX8rzY4+/YSyhBNQ+VcGEfdSsPfESYK6DrfHkkeVp7ObywH5QJmEY8JalOkwnXo= X-Received: by 2002:a24:d2:: with SMTP id 201-v6mr5030023ita.60.1534525587920; Fri, 17 Aug 2018 10:06:27 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:85c2:0:0:0:0:0 with HTTP; Fri, 17 Aug 2018 10:06:27 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201808170023.w7H0Np0H027296@repo.freebsd.org> <201808170503.w7H53GR9023607@slippy.cwsent.com> From: Warner Losh Date: Fri, 17 Aug 2018 11:06:27 -0600 X-Google-Sender-Auth: SuJ8nHHbDOD6inRWtYhG_Of5PQQ Message-ID: Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... To: "Conrad E. Meyer" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 17:06:29 -0000 On Fri, Aug 17, 2018 at 10:17 AM, Conrad Meyer wrote: > On Fri, Aug 17, 2018 at 9:12 AM, Warner Losh wrote: > > > > On Fri, Aug 17, 2018, 10:05 AM Conrad Meyer wrote: > >> We don't intend[sic] on tailoring it at all. > > > > We don't document such an exception... history tells me this belief may > be > > optimistic.. > > I think it is a generally understood convention re: contrib code. I > called out intent in the commit message for the directory, and anyway > it is generally frowned upon in the project to modify contrib code for > non-abandoned upstreams. E.g., there was quite a bit of resistance > modifying top(1) until it was deemed dead upstream and moved out of > contrib. > I don't understand this answer. It makes no sense to me. It certainly doesn't justify flaunting established project guidelines for dubious reasons. Warner