From owner-cvs-all@FreeBSD.ORG Fri Aug 13 18:17:10 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DD6E16A54B for ; Fri, 13 Aug 2004 18:17:09 +0000 (GMT) Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 92F6E43D39 for ; Fri, 13 Aug 2004 18:17:08 +0000 (GMT) (envelope-from rik@cronyx.ru) Received: (from root@localhost) by hanoi.cronyx.ru id i7DIE8PE050527 for cvs-all@FreeBSD.org.checked; (8.12.8/vak/2.1) Fri, 13 Aug 2004 22:14:08 +0400 (MSD) (envelope-from rik@cronyx.ru) Received: from cronyx.ru (hi.cronyx.ru [144.206.181.94]) by hanoi.cronyx.ru with ESMTP id i7DIDJmE050469; (8.12.8/vak/2.1) Fri, 13 Aug 2004 22:13:19 +0400 (MSD) (envelope-from rik@cronyx.ru) Message-ID: <411D04FE.70304@cronyx.ru> Date: Fri, 13 Aug 2004 22:14:22 +0400 From: Roman Kurakin User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Polstra References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_tap.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2004 18:17:10 -0000 John Polstra wrote: >On 13-Aug-2004 Roman Kurakin wrote: > > >>John Polstra wrote: >> >> >>>On 13-Aug-2004 Roman Kurakin wrote: >>> >>> >>>>John Polstra wrote: >>>> >>>> >>>>>That's pretty much correct. IFF_UP is an administrative control >>>>>that expresses the desired state of the interface. The driver never >>>>>changes IFF_UP. IFF_RUNNING is the driver's idea of the _actual_ >>>>> >>>>> >>>>> >>>>PPP state machine can remove IFF_UP. For example if connection is not >>>>persistent and link >>>>was broken for any reason. >>>> >>>> >>>> >>>I call that a bug. >>> >>> >>> >>This is not a bug, this is feature of protocol. Some times link should >>go down (or other >>state from which it could go up only by administrator (or program) >>intervention). >> >> >Sorry, but I disagree. PPP should clear IFF_RUNNING in that case, >but should leave IFF_UP untouched. > > But in that case we need some other way to bring line up again, since we unable just to ifconfig XXX up. This is possible to implement but very inconvenient. Could you describe why is so bad that some administrative action could be canceled due to protection or some other reasons by device state machine? Especially if users have a choice to allow this action or not. If users have a choice this action could be treated on behalf of administrator and thus like administrative action. rik >John > > > >