From owner-freebsd-ports@FreeBSD.ORG Mon Feb 21 17:30:39 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 2B34B16A593; Mon, 21 Feb 2005 17:30:38 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.3/8.13.1) with ESMTP id j1LHUQ18007437; Mon, 21 Feb 2005 12:30:26 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.3/8.13.1/Submit) id j1LHUPOi007436; Mon, 21 Feb 2005 12:30:25 -0500 (EST) (envelope-from green) Date: Mon, 21 Feb 2005 12:30:24 -0500 From: Brian Fundakowski Feldman To: Anton Berezin , ports@FreeBSD.org Message-ID: <20050221173024.GA1241@green.homeunix.org> References: <20050217204306.GA1116@green.homeunix.org> <20050221095009.GB60998@heechee.tobez.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050221095009.GB60998@heechee.tobez.org> User-Agent: Mutt/1.5.6i Subject: Re: portsperf (bsd.port.mk performance bugs fixed) redux X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2005 17:30:39 -0000 On Mon, Feb 21, 2005 at 10:50:09AM +0100, Anton Berezin wrote: > On Thu, Feb 17, 2005 at 03:59:13PM -0500, Brian Fundakowski Feldman wrote: > > Well, guys, it's been a while since the last installment of portsperf. > > Without further ado, here's a fix that bring port vulnerability check > > time down from almost two minutes to almost instantaneous (on my > > machine)! I was always wondering why ports have been so terribly slow > > since around some time last year, and a good 2000 pids get recycled > > just doing "make extract": > > <@green_> now: > > <@green_> green# time make extract > > <@green_> ===> Extracting for mp3gain-1.3.2 > > <@green_> => Checksum OK for mp3gain132_src.zip. > > <@green_> ===> mp3gain-1.3.2 depends on executable: unzip - found > > <@green_> 0.127u 1.132s 0:01.49 83.8% 108+497k 15+0io 8pf+0w > > > > <@green_> then: > > <@green_> green# time make extract > > <@green_> ===> Extracting for mp3gain-1.3.2 > > <@green_> => Checksum OK for mp3gain132_src.zip. > > <@green_> ===> mp3gain-1.3.2 depends on executable: unzip - found > > <@green_> 5.308u 82.765s 1:42.05 86.2% 92+193k 10+0io 12pf+0w > > > Index: bsd.port.mk > > =================================================================== > > RCS file: /usr/ncvs/ports/Mk/bsd.port.mk,v > > retrieving revision 1.509 > > diff -u -r1.509 bsd.port.mk > > --- bsd.port.mk 9 Feb 2005 09:07:37 -0000 1.509 > > +++ bsd.port.mk 17 Feb 2005 20:37:17 -0000 > > @@ -3009,14 +3009,18 @@ > > if [ "$$audit_created" -lt "$$audit_expiry" ]; then \ > > ${ECHO_MSG} "===> WARNING: Vulnerability database out of date, checking anyway"; \ > > fi; \ > > - vlist=`${_EXTRACT_AUDITFILE} | ${GREP} "${PORTNAME}" | \ > > - ${AWK} -F\| ' /^[^#]/ { \ > > Are you sure that the "then" part in your test was done with bsd.port.mk > that contains this `${GREP} "${PORTNAME}"' snippet, and not before it > was added? It is a recent addition, and it serves exactly the purpose > of speeding up vulnerabilities checking. Well, it's really not the same -- what about all the ports that have ${PORTNAME} listed already? They'll match that simplistic test, and still take several minutes to find out it's a false-positive, won't they? There should be quite a few instance of usedta-be-vulnerable ports, more than enough that it's worthwhile optimizing further... -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\