Date: Fri, 05 Oct 2012 13:57:43 +0300 From: Volodymyr Kostyrko <c.kworr@gmail.com> To: Gabor Kovesdan <gabor@FreeBSD.org> Cc: Oleg Moskalenko <oleg.moskalenko@citrix.com>, current@FreeBSD.org Subject: Re: [HEADSUP] Upcoming GNU sort removal Message-ID: <506EBD27.8040806@gmail.com> In-Reply-To: <506D6AA3.7010504@FreeBSD.org> References: <506D6AA3.7010504@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
04.10.2012 13:53, Gabor Kovesdan wrote: > it has been more than 3 months ago that BSD sort became default in HEAD > and no serious complaints have been raised against it since then so I > plan to permanently remove GNU sort from head in the next days. If you > have any objection, please raise it now. http://scan.freebsd.your.org/freebsd-head/usr.bin.grep/2012-01-12-amd64/ /usr/src/usr.bin/grep/regex/xmalloc.c:341:7: warning: Use of memory after it is freed hash_table_del(xmalloc_table, ptr); ^ ~~~ 1 warning generated. /usr/src/usr.bin/grep/regex/tre-fastmatch.c:534:3: warning: Result of 'malloc' is converted to a pointer of type 'unsigned int', which is incompatible with sizeof operand type 'int' FILL_BMGS; ^~~~~~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:343:19: note: expanded from macro 'FILL_BMGS' fg->sbmGs = xmalloc(fg->len * sizeof(int)); \ ^ /usr/src/usr.bin/grep/regex/xmalloc.h:69:23: note: expanded from macro 'xmalloc' #define xmalloc(size) malloc(size) ^~~~~~ ~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:537:3: warning: Result of 'malloc' is converted to a pointer of type 'unsigned int', which is incompatible with sizeof operand type 'int' FILL_BMGS_WIDE; ^~~~~~~~~~~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:359:18: note: expanded from macro 'FILL_BMGS_WIDE' fg->bmGs = xmalloc(fg->wlen * sizeof(int)); \ ^ /usr/src/usr.bin/grep/regex/xmalloc.h:69:23: note: expanded from macro 'xmalloc' #define xmalloc(size) malloc(size) ^~~~~~ ~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:707:3: warning: Memory is never released; potential leak of memory pointed to by 'tmp' STORE_MBS_PAT; ^~~~~~~~~~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:97:14: note: expanded from macro 'STORE_MBS_PAT' return REG_ESPACE; \ ^~~~~~~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:766:3: warning: Result of 'malloc' is converted to a pointer of type 'unsigned int', which is incompatible with sizeof operand type 'int' FILL_BMGS; ^~~~~~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:343:19: note: expanded from macro 'FILL_BMGS' fg->sbmGs = xmalloc(fg->len * sizeof(int)); \ ^ /usr/src/usr.bin/grep/regex/xmalloc.h:69:23: note: expanded from macro 'xmalloc' #define xmalloc(size) malloc(size) ^~~~~~ ~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:769:3: warning: Result of 'malloc' is converted to a pointer of type 'unsigned int', which is incompatible with sizeof operand type 'int' FILL_BMGS_WIDE; ^~~~~~~~~~~~~~ /usr/src/usr.bin/grep/regex/tre-fastmatch.c:359:18: note: expanded from macro 'FILL_BMGS_WIDE' fg->bmGs = xmalloc(fg->wlen * sizeof(int)); \ ^ /usr/src/usr.bin/grep/regex/xmalloc.h:69:23: note: expanded from macro 'xmalloc' #define xmalloc(size) malloc(size) ^~~~~~ ~~~~ 5 warnings generated. How about fixing http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/167921 ? > /usr/bin/grep "/tmp/ports/.amd_mnt/faz/host/usr/ports/textproc/docbook-410/work/\\." Segmentation fault (core dumped) > uname -a FreeBSD ar1l0u 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 r241156M: Wed Oct 3 13:58:16 EEST 2012 arcade@ar1l0u:/usr/obj/usr/src/sys/MINIMAL amd64 > gdb /usr/obj/usr/src/usr.bin/grep/grep grep.core GNU gdb 6.1.1 [FreeBSD] Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "amd64-marcel-freebsd"...(no debugging symbols found)... Core was generated by `grep'. Program terminated with signal 11, Segmentation fault. Reading symbols from /lib/libz.so.6...(no debugging symbols found)...done. Loaded symbols for /lib/libz.so.6 Reading symbols from /usr/lib/liblzma.so.5...(no debugging symbols found)...done. Loaded symbols for /usr/lib/liblzma.so.5 Reading symbols from /usr/lib/libbz2.so.4...(no debugging symbols found)...done. Loaded symbols for /usr/lib/libbz2.so.4 Reading symbols from /usr/lib/libgnuregex.so.5...(no debugging symbols found)...done. Loaded symbols for /usr/lib/libgnuregex.so.5 Reading symbols from /lib/libc.so.7...(no debugging symbols found)...done. Loaded symbols for /lib/libc.so.7 Reading symbols from /libexec/ld-elf.so.1...(no debugging symbols found)...done. Loaded symbols for /libexec/ld-elf.so.1 #0 0x00000000004069d2 in tre_compile_fast () (gdb) bt full #0 0x00000000004069d2 in tre_compile_fast () No symbol table info available. #1 0x0000000000404d06 in tre_fastncomp () No symbol table info available. #2 0x00000000004035b3 in main () No symbol table info available. -- Sphinx of black quartz, judge my vow.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?506EBD27.8040806>