From owner-freebsd-ports Sun Jul 14 5:27:14 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 484C537B400 for ; Sun, 14 Jul 2002 05:27:09 -0700 (PDT) Received: from smtp.noos.fr (aragon.noos.net [212.198.2.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3109043E42 for ; Sun, 14 Jul 2002 05:27:08 -0700 (PDT) (envelope-from root@gits.dyndns.org) Received: (qmail 6074528 invoked by uid 0); 14 Jul 2002 12:27:06 -0000 Received: from unknown (HELO gits.gits.dyndns.org) ([212.198.229.153]) (envelope-sender ) by 212.198.2.75 (qmail-ldap-1.03) with SMTP for ; 14 Jul 2002 12:27:06 -0000 Received: from gits.gits.dyndns.org (cb8bik0vcque9sfb@localhost [127.0.0.1]) by gits.gits.dyndns.org (8.12.5/8.12.5) with ESMTP id g6ECR5dT062522; Sun, 14 Jul 2002 14:27:06 +0200 (CEST) (envelope-from root@gits.dyndns.org) Received: (from root@localhost) by gits.gits.dyndns.org (8.12.5/8.12.5/Submit) id g6ECQxto062517; Sun, 14 Jul 2002 14:26:59 +0200 (CEST) (envelope-from root) Date: Sun, 14 Jul 2002 14:26:59 +0200 From: Cyrille Lefevre To: Alexander Leidinger Cc: dwcjr@inethouston.net, freebsd-ports@FreeBSD.ORG Subject: Re: ports/39606: Updated port: audio/lame (3.92) Message-ID: <20020714122659.GF35142@gits.dyndns.org> Mail-Followup-To: Cyrille Lefevre , Alexander Leidinger , dwcjr@inethouston.net, freebsd-ports@FreeBSD.ORG References: <20020713140358.GA35227@gits.dyndns.org> <200207131444.g6DEiOxQ098924@Magelan.Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200207131444.g6DEiOxQ098924@Magelan.Leidinger.net> User-Agent: Mutt/1.3.99i Organization: ACME X-Face: V|+c;4!|B?E%BE^{E6);aI.[< List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sat, Jul 13, 2002 at 04:44:24PM +0200, Alexander Leidinger wrote: > On 13 Jul, Cyrille Lefevre wrote: > > message resent due to mta misconfigation. > > > > On Thu, Jul 11, 2002 at 04:53:41AM +0200, Cyrille Lefevre wrote: > >> On Tue, Jul 09, 2002 at 11:13:41PM +0200, Alexander Leidinger wrote: > [...] > >> > [recent vorbis support] > >> > Are you willing to produce patches for configure.in/Makefile.am ... > >> what kind of patch ? vorbis rules already exists and there is > >> nothing to do w/ the fact that you NEED the vorbis sources > >> to build lame w/ vorbis support... this is absolutly non-standard. > >> except if you want something like --with-vorbis-prefix-src= ? > > Yes, and an explanation for the user why this is the case. as stated below, should the vorbis support added or deleted ? > >> also, from version to version vorbis change ther "internal" API > >> which is used by libmp3lame/vorbis_interface.c which need to be > >> adapted everytime to seek vorbis. not my fault. > > The FreeBSD ports tree is the only user of the vorbis part of lame. At > least your patches are responsible that it actually works with a recent > vorbis. Actually it isn't really supported by the LAME dev team and it > may vanish into the attic if nobody shows interest in keeping it up to > date. I know that. > >> [about the current version w/o SSE, gogo asm nor vorbis] > >> make test give me this on my machine (P200)... [snip] > Small differences are normal. It depends on the used compiler, the > options for the compiler, ... ok. > >> Index: Makefile > >> =================================================================== > >> RCS file: /home/ncvs/ports/audio/lame/Makefile,v > >> retrieving revision 1.21 > >> diff -u -r1.21 Makefile > >> --- Makefile 22 Apr 2002 01:22:48 -0000 1.21 > >> +++ Makefile 11 Jul 2002 02:29:01 -0000 > [...] > >> +.if !defined(WITHOUT_VORBIS) > >> +LIB_DEPENDS= vorbis.1:${PORTSDIR}/audio/libvorbis > > Do we really need vorbis support in LAME? The support was intended to > have a command line utility at a time where vorbis hadn't a good command > line utility. don't know, but since the code may support it, I left the choice to users. in other words, I hate incomplete ports... but, if you want to get rid of vorbis support, no problem. > >> +USE_GMAKE= yes > > It doesn't neet gmake. as a general rule, I always add USE_GMAKE in conjunction of GNU_CONFIGURE because, sometimes, not everything is build w/ a legacy make. I already got this issue w/ some ports (don't remember they names), so, I prefer to prevent this as a side rule. > >> +install-la: > >> + @${INSTALL_SCRIPT} ${WRKSRC}/libmp3lame/libmp3lame.la ${PREFIX}/lib > > We don't need the .la file. well, I'm just doing what's other ports do. Cyrille. -- Cyrille Lefevre mailto:cyrille.lefevre@laposte.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message