From owner-freebsd-net@FreeBSD.ORG Thu May 20 13:55:24 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91EE416A4CE for ; Thu, 20 May 2004 13:55:24 -0700 (PDT) Received: from mailtoaster1.pipeline.ch (mailtoaster1.pipeline.ch [62.48.0.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEBF843D49 for ; Thu, 20 May 2004 13:55:23 -0700 (PDT) (envelope-from andre@freebsd.org) Received: (qmail 45453 invoked from network); 20 May 2004 20:55:22 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by mailtoaster1.pipeline.ch (qmail-ldap-1.03) with SMTP for ; 20 May 2004 20:55:22 -0000 Message-ID: <40AD1B39.AAF75D9D@freebsd.org> Date: Thu, 20 May 2004 22:55:21 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <20040518092439.GF845@darkness.comp.waw.pl> <20040518024346.A5068@xorpc.icir.org> <20040518100503.GG845@darkness.comp.waw.pl> <20040518034756.A9648@xorpc.icir.org> <20040520152127.GP845@darkness.comp.waw.pl> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: Luigi Rizzo cc: freebsd-net@freebsd.org Subject: Re: ia_netbroadcast X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2004 20:55:24 -0000 Pawel Jakub Dawidek wrote: > > On Tue, May 18, 2004 at 03:47:56AM -0700, Luigi Rizzo wrote: > +> On Tue, May 18, 2004 at 12:05:03PM +0200, Pawel Jakub Dawidek wrote: > +> ... > +> > +> > Do we still need ia_netboradcast field? It is calculated depending on > +> > +> > old-fashion classes (A, B, C). Is it used still? > +> > +> > I wonder if ia_broadaddr isn't sufficient today. > +> > +> > +> > +> not just that, it seems that ia_netboradcast contains bogus info. > +> > > +> > So? > +> > +> nuke it! > +> Also if, as Andre said, it might be used by windows apps, > +> one could certainly compute it on the fly from the IP address. > > Ok, this patch: > > http://people.freebsd.org/~pjd/patches/no_old_style_nets.patch > > removes ia_netbroadcast, ia_net, ia_netmask field from structure > in_ifaddr and removes sysctl net.inet.ip.subnets_are_local as suggested > in commit log of revision 1.24 of file netinet/in.c: > > Set subnetsarelocal to false. In a classless world, the other case > is almost never useful. (This is only a quick hack; someone should > go back and delete the entire subnetsarelocal==1 code path.) > > Tests and comments are welcome. I have checked that at least Win2k doesn't use the classful broadcast address anymore. I don't know about older versions of Windows. However I'm not yet sure we (better I) understand all implications of removing the things you do in your patch. Please hold off for a moment until I've finished thinking and looking through the implications. -- Andre