From owner-freebsd-current@FreeBSD.ORG Mon Apr 19 09:24:48 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B57E16A4D0 for ; Mon, 19 Apr 2004 09:24:48 -0700 (PDT) Received: from mail.gmx.net (mail.gmx.de [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id A9FBB43D39 for ; Mon, 19 Apr 2004 09:24:47 -0700 (PDT) (envelope-from andreas.kohn@gmx.net) Received: (qmail 19193 invoked by uid 65534); 19 Apr 2004 16:24:46 -0000 Received: from unknown (EHLO [212.204.44.203]) (212.204.44.203) by mail.gmx.net (mp007) with SMTP; 19 Apr 2004 18:24:46 +0200 X-Authenticated: #2431876 From: Andreas Kohn To: Luigi Rizzo In-Reply-To: <20040419013627.A88297@xorpc.icir.org> References: <1082303878.855.6.camel@klamath.syndrom23.de> <20040419013627.A88297@xorpc.icir.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-7vmnOwMLm9fsowqoZBGN" Message-Id: <1082391882.786.0.camel@klamath.syndrom23.de> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Mon, 19 Apr 2004 18:24:42 +0200 cc: current@freebsd.org Subject: [SOLVED] Re: Page fault in rt_newaddrmsg on gif0 destruction X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Apr 2004 16:24:48 -0000 --=-7vmnOwMLm9fsowqoZBGN Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2004-04-19 at 10:36, Luigi Rizzo wrote:=20 > Ok i understand what is going on (thanks for the very detailed > report, btw) -- basically the code was trying to use > ifadd_byindex() after the information had been destroyed. >=20 > I think the attached patch (basically mving a block of code down > in if_detach) should fix the problem. >=20 > Actually I believe this particular chunk of code should be moved > even further down, possibly right before the final IF_AFDATA_UNLOCK(), > because you cannot tell, a-priori, what information on the device > the lower level routines expect to use, so zeroing the ifindex_table[] > or calling destroy_dev() too early is probably a bug. >=20 > If you can try it (in the proposed form, or moving it at the end > of if_detach) and let me khow how it works for you, i can commit > the fix. >=20 > cheers > luigi Hi, thank you, that one works perfectly.=20 Regards, Andreas --=-7vmnOwMLm9fsowqoZBGN Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAg/1KYucd7Ow1ygwRAs79AJ9OA6sb0vpYXYvGkozgL6/IymWLtgCeLHjG q6HkWo6fZZ1XH3KQEBT5ERc= =bWlO -----END PGP SIGNATURE----- --=-7vmnOwMLm9fsowqoZBGN--