From owner-svn-src-head@freebsd.org Mon Nov 26 23:29:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D33EE114890A for ; Mon, 26 Nov 2018 23:29:37 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:d12:604::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 599B170F66; Mon, 26 Nov 2018 23:29:37 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id wAQNTURf060404 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Nov 2018 00:29:31 +0100 (CET) (envelope-from eugen@freebsd.org) X-Envelope-From: eugen@freebsd.org X-Envelope-To: jhb@FreeBSD.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id wAQNTTJe052666 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 27 Nov 2018 06:29:30 +0700 (+07) (envelope-from eugen@freebsd.org) Subject: Re: svn commit: r340617 - head/sys/netgraph To: John Baldwin , src-committers@freebsd.org, svn-src-head@freebsd.org References: <201811190727.wAJ7RpDN052165@repo.freebsd.org> From: Eugene Grosbein Message-ID: <5e7d2e8e-2a06-e687-f4c1-5c30ee4c50be@freebsd.org> Date: Tue, 27 Nov 2018 06:29:24 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 599B170F66 X-Spamd-Result: default: False [0.77 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.10)[-0.102,0]; NEURAL_SPAM_LONG(0.75)[0.746,0]; NEURAL_SPAM_SHORT(0.13)[0.129,0]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 23:29:38 -0000 27.11.2018 4:26, John Baldwin wrote: >> /* Parse type for timeval */ >> static const struct ng_parse_struct_field ng_source_timeval_type_fields[] = { >> +#ifdef __LP64__ >> + { "tv_sec", &ng_parse_int64_type }, >> + { "tv_usec", &ng_parse_int64_type }, >> +#else >> { "tv_sec", &ng_parse_int32_type }, >> { "tv_usec", &ng_parse_int32_type }, >> +#endif >> { NULL } > > time_t (and thus tv_sec) is 64 bits on all but i386 now. tv_usec is still a > long, so follows LP64 though. If this is trying to match an actual struct > timeval then you might want something like this: > > #ifdef __i386__ > { "tv_sec", &ng_parse_int32_type }, > #else > { "tv_sec", &ng_parse_int64_type }, > #endif > #ifdef __LP64__ > { "tv_usec", &ng_parse_int32_type }, > #else > { "tv_usec", &ng_parse_int64_type }, > #endif I'm not sure I get it right: do you mean there is a difference for some platform we have?