From owner-svn-src-head@freebsd.org Sun May 31 15:22:22 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CC9F233760A; Sun, 31 May 2020 15:22:22 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 49Zhqx4TV6z4GRZ; Sun, 31 May 2020 15:22:21 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id fPmzjMmbt62brfPn1jkdWk; Sun, 31 May 2020 09:22:19 -0600 X-Authority-Analysis: v=2.3 cv=LKf9vKe9 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=sTwFKg_x9MkA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=9BAg3rB5dSc8KMoodngA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id B41E212EA; Sun, 31 May 2020 08:22:16 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id 04VFMGul015503; Sun, 31 May 2020 08:22:16 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id 04VFMF4U015500; Sun, 31 May 2020 08:22:16 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202005311522.04VFMF4U015500@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Hartmann, O." cc: John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r361633 - in head/sys: net netipsec In-reply-to: <20200531114318.2b415934@hermann.fritz.box> References: <202005291922.04TJMemQ098017@repo.freebsd.org> <20200531114318.2b415934@hermann.fritz.box> Comments: In-reply-to "Hartmann, O." message dated "Sun, 31 May 2020 11:43:18 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 31 May 2020 08:22:15 -0700 X-CMAE-Envelope: MS4wfMHoJGqmYJvHIvZtIKF3SKdvxhKp1sA0yO/Rq3SJB7zD5kbTcSHxiOFDokMzeILTykUcssiVjVLGe1hTLdDhc/pEWmA13g4EChLVj30T5DbwP1GtJgc+ 5oUkAfoj3RcIrpVLANmhZYL7jxTcoj24ks6GNbKQ+401YTZ6X3sppWtkZmQkFWEtyoschvyjXHsllPEng0KMj55GE6obye2g7ESoAz+PZYrw5uGZ6RhWslIW 9L7Q9/JvDOJYhwg0vTTJt/RlU090aCCQwuK+P1exQoN47CFXuM70nFDWcgsLlRkdbA14xts9dpiJdHWR5aySsw== X-Rspamd-Queue-Id: 49Zhqx4TV6z4GRZ X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.134.12) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [0.89 / 15.00]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; RWL_MAILSPIKE_GOOD(0.00)[64.59.134.12:from]; HAS_XAW(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[70.67.125.17:received]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_LOW(-0.10)[64.59.134.12:from]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.71)[-0.705]; RCVD_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.66)[0.662]; NEURAL_HAM_LONG(-0.36)[-0.364]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; AUTH_NA(1.00)[]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 May 2020 15:22:22 -0000 In message <20200531114318.2b415934@hermann.fritz.box>, "Hartmann, O." writes: > --Sig_/K9D9Cgo_rXCeD=+Maiy_5WL > Content-Type: text/plain; charset=US-ASCII > Content-Transfer-Encoding: quoted-printable > > On Fri, 29 May 2020 19:22:40 +0000 (UTC) > John Baldwin wrote: > > > Author: jhb > > Date: Fri May 29 19:22:40 2020 > > New Revision: 361633 > > URL: https://svnweb.freebsd.org/changeset/base/361633 > >=20 > > Log: > > Consistently include opt_ipsec.h for consumers of > > .=20 > > This fixes ipsec.ko to include all of IPSEC_DEBUG. > > =20 > > Reviewed by: imp > > MFC after: 2 weeks > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D25046 > >=20 > > Modified: > > head/sys/net/if_enc.c > > head/sys/net/if_ipsec.c > > head/sys/netipsec/ipsec.h > > head/sys/netipsec/ipsec_mbuf.c > > head/sys/netipsec/xform_ah.c > > head/sys/netipsec/xform_esp.c > > head/sys/netipsec/xform_ipcomp.c > >=20 > > Modified: head/sys/net/if_enc.c [...] > > > In my case, kernel build (make buildkernel) fails with the comnpiler > error shown below while compiling ipsec kernel module. Kernel has IPSEC > support enabled. > > Kind regards, > oh > > [...] > --- all_subdir_ipsec --- > --- ipsec_mod.o --- > /usr/src/sys/netipsec/ipsec_mod.c:114:3: error: implicit declaration of > function 'ipsec_support_enable' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > ipsec_support_enable(ipv4_ipsec_support, &ipv4_methods); ^ > /usr/src/sys/netipsec/ipsec_mod.c:125:3: error: implicit declaration of > function 'ipsec_support_disable' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > ipsec_support_disable(ipv4_ipsec_support); ^ --- all_subdir_ipwfw --- > Building > /usr/obj/usr/src/amd64.amd64/sys/WALHALL/modules/usr/src/sys/modules/ipwfw/= > ipw_bss/ipw_bss.ko > --- all_subdir_ipsec --- /usr/src/sys/netipsec/ipsec_mod.c:125:3: note: > did you mean 'ipsec_support_enable'? > /usr/src/sys/netipsec/ipsec_mod.c:114:3: note: 'ipsec_support_enable' > declared here ipsec_support_enable(ipv4_ipsec_support, &ipv4_methods); > ^ 2 errors generated. *** [ipsec_mod.o] Error code 1 > > make[4]: stopped in /usr/src/sys/modules/ipsec Can you post your kernel config, please. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.