From owner-freebsd-ports@FreeBSD.ORG  Wed Jul 13 04:17:55 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id B62501065674;
	Wed, 13 Jul 2011 04:17:55 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id B76FC14D993;
	Wed, 13 Jul 2011 04:17:53 +0000 (UTC)
Message-ID: <4E1D1C70.4050505@FreeBSD.org>
Date: Tue, 12 Jul 2011 21:17:52 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:5.0) Gecko/20110706 Thunderbird/5.0
MIME-Version: 1.0
To: Stephen Montgomery-Smith <stephen@missouri.edu>
References: <201107121826.00020.jkim@FreeBSD.org> <4E1D1A21.601@missouri.edu>
In-Reply-To: <4E1D1A21.601@missouri.edu>
X-Enigmail-Version: 1.2pre
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Pav Lucistnik <pav@FreeBSD.org>,
	Stephen Montgomery-Smith <stephen@FreeBSD.org>,
	Jung-uk Kim <jkim@FreeBSD.org>,
	"freebsd-ports@FreeBSD.org" <freebsd-ports@FreeBSD.org>
Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jul 2011 04:17:55 -0000

On 07/12/2011 21:08, Stephen Montgomery-Smith wrote:
> Thinking more about it, it seems to me that instead of silently deleting
> the disallowed characters in the filename, that the port should declare
> itself broken if there are disallowed characters.  That way, this
> particular error would have been caught far more easily.

I was thinking along similar lines. My concern would be that if the
change to allow - and _ is done silently that it will break plists.


Doug

-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/