From owner-freebsd-net@FreeBSD.ORG Mon Jun 21 16:37:23 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E148116A4CE for ; Mon, 21 Jun 2004 16:37:23 +0000 (GMT) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE10543D48 for ; Mon, 21 Jun 2004 16:37:23 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc12) with ESMTP id <200406211637230140021cq7e>; Mon, 21 Jun 2004 16:37:23 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id JAA36910; Mon, 21 Jun 2004 09:37:21 -0700 (PDT) Date: Mon, 21 Jun 2004 09:37:19 -0700 (PDT) From: Julian Elischer To: Brian Somers In-Reply-To: <20040621171208.675354ae@dev.lan.Awfulhak.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Yohan cc: freebsd-net@freebsd.org Subject: Re: PPPoE X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2004 16:37:24 -0000 On Mon, 21 Jun 2004, Brian Somers wrote: > On Mon, 21 Jun 2004 05:55:41 -0700 (PDT), Yohan wrote: > > PPPoE PADI [Host-Uniq UTF8] > > PPPoE PADO [AC-Name "BANYAN"] [AC-Cookie UTF8] [Service-Name] [Relay-Session-ID UTF8] [Host-Uniq UTF8] > > PPPoE PADR [Host-Uniq UTF8] [AC-Cookie UTF8] [AC-Name "BANYAN"] > > And the missing bit is the PADS packet (which we're expecting from the > PPPoE server). Here, the netgraph node is resending the PADR after 2 > seconds of inactivity, then dropping back to sending a PADI all over > again. > > Interestingly enough, the PADR doesn't seem to have the Service-Name > or Relay-Session-ID tags that the PADO has - perhaps that's what's > causing the problem... certainly the PADO handling code that sends > the PADS calls scan_tags() which is supposed to copy tags not already > handled from the PADO into the PADR. One of the #defines in ng_pppoe is wrong and has been corrected.. he's going to retry for us with the new version. however without going to look at the code again I couldn't say why the PADR didn't copy the service name Good to see you back Brian.. we've missed you (especially with ppp questions :-) > > Julian, have you any comments on this ? > > Cheers. > > -- > Brian > > Don't _EVER_ lose your sense of humour ! >