Date: Wed, 6 May 2020 08:22:20 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Pietro Cerutti <gahr@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r534039 - head/devel/dbus-tcl Message-ID: <20200506082220.GA58859@FreeBSD.org> In-Reply-To: <202005050822.0458MeU2007319@repo.freebsd.org> References: <202005050822.0458MeU2007319@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 05, 2020 at 08:22:40AM +0000, Pietro Cerutti wrote: > New Revision: 534039 > URL: https://svnweb.freebsd.org/changeset/ports/534039 > > Log: > devel/dbus-tcl: unbreak by updating master site Something's not right about this. The version has not changed, but the distfile is different now: > -SHA256 (dbus-2.1.tar.gz) = 82c116cb7b70cdd7183e1054f2c52363aab7c608b5fb375dbb129f080734e2d0 > -SIZE (dbus-2.1.tar.gz) = 173734 > +TIMESTAMP = 1588663324 > +SHA256 (dbus-2.1.tar.gz) = 03f5314d5ba334a498ca30dac492a88ba9300480a0c0a4d39231c54b21654bb8 > +SIZE (dbus-2.1.tar.gz) = 159437 When this happens, it must be explained in the commit log. This requires having two distfiles and reviewing "diff -rudp" output. > Also, use gmake to build. Why? Is it related to the distfile change? What was the rationale for this? Neither commit log nor PR backlog explain it. > PR: 246165 > Submitted by: Chris Hutchinson <portmaster@bsdforge.com> Please do not blindly apply Chris' patches, they often require polishing. > +++ head/devel/dbus-tcl/pkg-descr Tue May 5 08:22:39 2020 (r534039) > @@ -2,4 +2,4 @@ The DBus-Tcl project provides a Tcl interface to the d > It contains packages that allow Tcl programs to send and receive dbus signals, > as well as invoke and respond to dbus method calls. > > -WWW: http://dbus-tcl.sf.net > +http://chiselapp.com/user/schelte/repository/dbus/home Why remove the "WWW:" prefix? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200506082220.GA58859>