From owner-freebsd-i386@FreeBSD.ORG Sun Feb 13 18:10:36 2005 Return-Path: Delivered-To: freebsd-i386@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54E1516A4CE for ; Sun, 13 Feb 2005 18:10:36 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3150143D2F for ; Sun, 13 Feb 2005 18:10:36 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1DIAaEJ037795 for ; Sun, 13 Feb 2005 18:10:36 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1DIAaIP037794; Sun, 13 Feb 2005 18:10:36 GMT (envelope-from gnats) Date: Sun, 13 Feb 2005 18:10:36 GMT Message-Id: <200502131810.j1DIAaIP037794@freefall.freebsd.org> To: freebsd-i386@FreeBSD.org From: David Schultz Subject: Re: i386/67469: src/lib/msun/i387/s_tan.S gives incorrect results for large inputs X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: David Schultz List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Feb 2005 18:10:36 -0000 The following reply was made to PR i386/67469; it has been noted by GNATS. From: David Schultz To: Bruce Evans Cc: FreeBSD-gnats-submit@FreeBSD.ORG, freebsd-i386@FreeBSD.ORG, bde@FreeBSD.ORG Subject: Re: i386/67469: src/lib/msun/i387/s_tan.S gives incorrect results for large inputs Date: Sun, 13 Feb 2005 13:08:37 -0500 On Mon, Feb 14, 2005, Bruce Evans wrote: > It seems that the hardware trig functions aren't worth using. I want > to test them on a 486 and consider the ranges more before discarding > them. This may take a while. Fair enough. I would be happy to have a hybrid implementation that uses the hardware only when appropriate. However, your 486 benchmarks notwithstanding, I would just as soon rely on fdlibm entirely for the trig functions. It just doesn't seem worthwhile to me, given that the only parts of the domain where the hardware is faster *and* correct are, roughly speaking, [0,2^-28) and [pi/4,pi/2-eps]. > I did a quick test of some other functions: > - hardware sqrt is much faster > - hardware exp is slightly faster on the range [1,100] > - hardware atan is slower on the range [0,1.5] > - hardware acos is much slower (139 nsec vs 57 nsec!) on the range [0,1.0]. sqrt isn't transcendental, so it should be faster and correctly rounded on every hardware platform. I found similar results to yours for atan() and acos() when writing amd64 math routines, but of course amd64 has the overhead of switching between the SSE and i387 units. Maybe they should go away, too...