From owner-svn-src-all@FreeBSD.ORG Mon Dec 6 22:40:55 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4AF75106566B; Mon, 6 Dec 2010 22:40:55 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-qw0-f50.google.com (mail-qw0-f50.google.com [209.85.216.50]) by mx1.freebsd.org (Postfix) with ESMTP id 9659F8FC0A; Mon, 6 Dec 2010 22:40:54 +0000 (UTC) Received: by qwd6 with SMTP id 6so1887879qwd.37 for ; Mon, 06 Dec 2010 14:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=aCH5Nq4wJK8+djuqfzoz3+pQWB6xN7jBSQMOHUdmW+I=; b=D2OpiX2ngaK5EKY2ZpnVKlo4XuaYL+JgbcKnzyO5NjIcpn42dLWzYrkVtdyKCj1Q8h 8VaV+HBZRIOe9bj+oQLkzEVI6ggYXPcg8FL2bLYijsMvgcIb13p6E9zy/HnUNjh/r6YB OdTpa62JPv3Fkhn8uGUU9B7O8d2J/cJYqH5l4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=R/l6xyM3jbDncZm6X1dXWI0dMmFNUsNTxYU2G3ZksqGGuph4we88AZKAwvhmTGpxMk aXuC1B8LxKvbQYty6iRT7fDJA4CBmmGuh+AGDG0aQfC0xK715h0stgT+zJbnoW52Dxy3 u5GHFk+/mwLrGS0W53pNJ4A3u77rgRoQCg75o= Received: by 10.229.228.146 with SMTP id je18mr5057964qcb.47.1291675253159; Mon, 06 Dec 2010 14:40:53 -0800 (PST) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.229.231.143 with HTTP; Mon, 6 Dec 2010 14:40:13 -0800 (PST) In-Reply-To: <4CFD6575.5040202@freebsd.org> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206211607.GA65110@muon.cran.org.uk> <201012061700.49219.jhb@freebsd.org> <4CFD6575.5040202@freebsd.org> From: Ivan Voras Date: Mon, 6 Dec 2010 23:40:13 +0100 X-Google-Sender-Auth: HxfCH7tVDDCbDVHFqv9l3luAHzQ Message-ID: To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Bruce Cran , src-committers@freebsd.org, Pawel Jakub Dawidek , John Baldwin , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2010 22:40:55 -0000 On 6 December 2010 23:36, Andriy Gapon wrote: > on 07/12/2010 00:00 John Baldwin said the following: >> It is probably the 4K logical sector size that needs to >> come up with a new field, not vice versa. > > Just expressing my overall confusion - 4K would be the physical size and = 512 > would be the logical one? =C2=A0My thinking: on a platter it's a 4K secto= r, but drive > supports data addressing with 512 byte granularity. Yes, the whole thing is overly complicated by the need for 512/4096 kludge; The cleanest would be to simply go with One True Sector Size (4 KiB) for the drive which support it but that would break compatibility all over the place (including booting). Upthread I've advocated adding an "physsectorsize" field for this, but basically I'm fine either way.