From owner-freebsd-bugs@freebsd.org Thu Apr 2 20:48:55 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A56F4264757 for ; Thu, 2 Apr 2020 20:48:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48tZsw4063z4cbQ for ; Thu, 2 Apr 2020 20:48:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id AB9A6264748; Thu, 2 Apr 2020 20:48:45 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8848264744 for ; Thu, 2 Apr 2020 20:48:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48tZsj6V47z4cXl for ; Thu, 2 Apr 2020 20:48:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B5F391FB6F for ; Thu, 2 Apr 2020 20:48:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 032KmYq3020626 for ; Thu, 2 Apr 2020 20:48:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 032KmYVY020625 for bugs@FreeBSD.org; Thu, 2 Apr 2020 20:48:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 245296] [patch] ruptime leaves spurious extra spaces for the load average of machines that are down Date: Thu, 02 Apr 2020 20:48:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: martin@lispworks.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 20:48:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245296 Bug ID: 245296 Summary: [patch] ruptime leaves spurious extra spaces for the load average of machines that are down Product: Base System Version: 11.3-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: martin@lispworks.com Created attachment 212992 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D212992&action= =3Dedit Fix maxloadav calculation The calculation for maxloadav in usr.bin/ruptime/ruptime.c includes machines that are down, even though the load averages for those machines are not printed. This can leave spurious extra spaces when printing the load avera= ges if a machine is down with a load >=3D 10. For example, I see output like this with two spaces before the 0.00 for methane: methane up 6+10:55, 0 users, load 0.00, 0.00,= =20 0.00 odroid down 20:10 because the load average for odroid was 28 before it stopped responding. It should be like this: methane up 6+10:55, 0 users, load 0.00, 0.00, 0.= 00 odroid down 20:10 This is fixed by the attached patch. --=20 You are receiving this mail because: You are the assignee for the bug.=