From owner-svn-ports-all@FreeBSD.ORG  Sat Apr 25 14:38:59 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 830CE510;
 Sat, 25 Apr 2015 14:38:59 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D790215F7;
 Sat, 25 Apr 2015 14:38:58 +0000 (UTC)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 36179abe;
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Sat, 25 Apr 2015 08:38:55 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: svn commit: r384682 - in head/security/keychain: . files
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <20150425150722.568d8d52eb71eb774c29a70a@FreeBSD.org>
Date: Sat, 25 Apr 2015 08:38:54 -0600
Cc: Renato Botelho <garga@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, adamw@FreeBSD.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8CD89C9F-D73F-494B-8F93-102CFBE5C0A0@adamw.org>
References: <201504242009.t3OK9vtp090926@svn.freebsd.org>
 <20150425114020.4743fe0a5771addb3db585b9@FreeBSD.org>
 <20150425150722.568d8d52eb71eb774c29a70a@FreeBSD.org>
To: Emanuel Haupt <ehaupt@FreeBSD.org>
X-Mailer: Apple Mail (2.2098)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Apr 2015 14:38:59 -0000

> On 25 Apr, 2015, at 7:07, Emanuel Haupt <ehaupt@FreeBSD.org> wrote:
>=20
> Emanuel Haupt <ehaupt@FreeBSD.org> wrote:
>> Renato Botelho <garga@FreeBSD.org> wrote:
>>> Author: garga
>>> Date: Fri Apr 24 20:09:57 2015
>>> New Revision: 384682
>>> URL: https://svnweb.freebsd.org/changeset/ports/384682
>>>=20
>>> Log:
>>>  Update to 2.8.0
>>>=20
>>>  PR:		199300 (based on)
>>>  Submitted by:	adamw@
>>=20
>> After the update I get:
>>=20
>> $ keychain=20
>> /usr/local/bin/keychain: shopt: not found
>> /usr/local/bin/keychain: 848: Syntax error: "(" unexpected (expecting
>> ")")
>>=20
>=20
> Looking at it a bit closer shows that the new version sets:
>=20
> shopt -s extglob
>=20
> but uses:
>=20
> #!/bin/sh
>=20
> This is probably no problem on most Linuxes that simply link /bin/sh
> to /bin/bash but it won't work on FreeBSD.
>=20
> The way I see it keychain needs to either start using
>=20
> #!/usr/local/bin/bash
>=20
> as shebang or the expressions that require extglob need to be
> made FreeBSD /bin/sh compatible. The first one is IMHO better
> for future maintainability.

You're completely right. I botched the patch. I've attached a patch that =
fixes that (as well as removing stale dependencies that I should have =
included in the original patch) to the original PR, 199300.

Sorry, garga.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org