From owner-cvs-src@FreeBSD.ORG Wed Jul 2 00:58:27 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B65C2106567A; Wed, 2 Jul 2008 00:58:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 4CF788FC27; Wed, 2 Jul 2008 00:58:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m620wKVN035257; Tue, 1 Jul 2008 20:58:20 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: src-committers@freebsd.org Date: Tue, 1 Jul 2008 17:46:32 -0400 User-Agent: KMail/1.9.7 References: <200807011944.m61JinOJ070044@repoman.freebsd.org> In-Reply-To: <200807011944.m61JinOJ070044@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807011746.33319.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Tue, 01 Jul 2008 20:58:21 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/7612/Tue Jul 1 19:13:47 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.3 required=4.2 tests=AWL,BAYES_00, DATE_IN_PAST_03_06,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, gibbs@freebsd.org, mjacob@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2008 00:58:27 -0000 On Tuesday 01 July 2008 03:44:38 pm John Baldwin wrote: > jhb 2008-07-01 19:44:38 UTC > > FreeBSD src repository > > Modified files: > sys/dev/mpt mpt_pci.c > Log: > SVN rev 180152 on 2008-07-01 19:44:38Z by jhb > > During shutdown, deregister the shutdown hook from the correct event > handler. > > MFC after: 2 weeks Even having an eventhandler here is dubious as the shutdown routine is already called by new-bus. At one point there was a comment suggesting that new-bus called it too late? If that is still the case, then we should probably move it to shutdown_final() and remove the 'device_shutdown' hook so new-bus doesn't call it. However, if it is fine the way it is, we should remove the explicit eventhandler so it only gets invoked once. -- John Baldwin