From owner-svn-src-head@FreeBSD.ORG Tue Dec 23 21:06:22 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01FE91065673; Tue, 23 Dec 2008 21:06:22 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 97B2E8FC24; Tue, 23 Dec 2008 21:06:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LFESD-0001XF-3Z; Tue, 23 Dec 2008 23:06:17 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mBNL6AoN048628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 23 Dec 2008 23:06:10 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mBNL6Acv098707; Tue, 23 Dec 2008 23:06:10 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mBNL6AUY098706; Tue, 23 Dec 2008 23:06:10 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 23 Dec 2008 23:06:10 +0200 From: Kostik Belousov To: Joe Marcus Clarke Message-ID: <20081223210610.GK74688@deviant.kiev.zoral.com.ua> References: <200812232043.mBNKhgkJ013132@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sdEQJo40s7ofW8iR" Content-Disposition: inline In-Reply-To: <200812232043.mBNKhgkJ013132@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LFESD-0001XF-3Z dbcd289965a513af6e85af8775c3df86 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186458 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2008 21:06:22 -0000 --sdEQJo40s7ofW8iR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 23, 2008 at 08:43:42PM +0000, Joe Marcus Clarke wrote: > Author: marcus (doc,ports committer) > Date: Tue Dec 23 20:43:42 2008 > New Revision: 186458 > URL: http://svn.freebsd.org/changeset/base/186458 >=20 > Log: > Do not KASSERT when vp->v_dd is NULL. Only directories which have had = ".." > looked up would have v_dd set to a non-NULL value. This fixes a panic I was very unaccurate in my formulation to the point where the statement should be considered plain wrong. This does not invalidate the commit, but the way to say this is v_dd is set to NULL by ".." lookups for directories that are not cached as the dst for their names. > seen when running installworld on a diskless system with a separate /usr > file system. > =20 > Submitted by: cracauer > Approved by: kib >=20 > Modified: > head/sys/kern/vfs_cache.c >=20 > Modified: head/sys/kern/vfs_cache.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/vfs_cache.c Tue Dec 23 20:25:04 2008 (r186457) > +++ head/sys/kern/vfs_cache.c Tue Dec 23 20:43:42 2008 (r186458) > @@ -936,7 +936,7 @@ vn_fullpath1(struct thread *td, struct v > } > ncp =3D TAILQ_FIRST(&vp->v_cache_dst); > if (ncp !=3D NULL) { > - MPASS(ncp->nc_dvp =3D=3D vp->v_dd); > + MPASS(vp->v_dd =3D=3D NULL || ncp->nc_dvp =3D=3D vp->v_dd); > buflen -=3D ncp->nc_nlen - 1; > for (i =3D ncp->nc_nlen - 1; i >=3D 0 && bp !=3D buf; i--) > *--bp =3D ncp->nc_name[i]; --sdEQJo40s7ofW8iR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklRUsEACgkQC3+MBN1Mb4gHogCdFFv8lkCRXmfwmYRkMV3x06Py ZhkAoJhPyZ+8v3PxxOZiGv7uz68ZDrY4 =GIQ3 -----END PGP SIGNATURE----- --sdEQJo40s7ofW8iR--