From nobody Mon Jan 15 16:37:48 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TDHrF5tHhz57JJv for ; Mon, 15 Jan 2024 16:38:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TDHrF41B3z3wxK for ; Mon, 15 Jan 2024 16:38:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40e5f746ac4so53556465e9.1 for ; Mon, 15 Jan 2024 08:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1705336683; x=1705941483; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1ceMknBT1cssMzV6VxDtTWssN92LyHmn3DoHcJbITUg=; b=fRmaMdkTMzqFp6riiullwwOorXIzPbycjrhntEMp5CemvZ0iuPbc2OZcw3TkU07Kej MXwcNu7gxi49WkyRMHG6TttZMLovgG2Sr/IwOId+TCKI0i0RiIe50SRTt151rqTBPKEM D8Kqk1ABUC7R+WRLugvjZ6RrtsmOJPQ/IbJo4fFBcFNdx7atAN/T084iU5YpRGUzIDgX aODfOAgHQrJdgsEarKZYUi+3QzHZqFSHlvsOMma6JmJgDog6aHTu9BEfmOgbDazzPjXu FkO+qxZGeox4ckLnuc/JaS2t2BiWd/0N8+sBRlZmXrtAPgJDbSQ44SKC2FX7oAm9Eomc ltHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705336683; x=1705941483; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1ceMknBT1cssMzV6VxDtTWssN92LyHmn3DoHcJbITUg=; b=MFj7SrYWZRFycSSyQQJ8E1F55CHjyf9Loy7Yk6sHh9K11PwYbeMznysuqDFXrBcdN8 kmgrWXIlAvR2r0fFBq1PFy67UJ1fVe02q6ORQDBH7qJU7eCKgfkG/joihcPCQVcCIUJR zfkw6ziFupMGeIOQ1vmeCRQq/gYfwxOb8LFYFe0T2WTJtomO3QxurRoFbCOjWtbD554U OWNwiwjr0op24JGXSpBrrJh94T5TyuQULveYNhQAD2BTRzKRoRzkOSSfalgAxSHpAMst Wv9h2DwRS54GANtR+VcAmFUG+aDzrqo2cM8T6A/7h10g9svNrfVKxme5WyJIlC0w80R9 xnlw== X-Gm-Message-State: AOJu0YyGmgsixX7h9zAq8Ows4+sROrsrAXZirznOqjmSWSReZbFHt0qx TTx5ONH1FC33QXpwOQIlC1140llI5hfv4PsaRYqW3vxvn+b3yQ== X-Google-Smtp-Source: AGHT+IGpi804q3bQkUJ66/THg5gKLkPpJk9BE24UEA+eu4ix49AbN8yaWuE6++rhFjeDRi4rOo6fa6NYTr/5H7XBZ7o= X-Received: by 2002:a05:600c:4d1e:b0:40e:42b0:b75d with SMTP id u30-20020a05600c4d1e00b0040e42b0b75dmr3473239wmp.42.1705336683306; Mon, 15 Jan 2024 08:38:03 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202401150224.40F2OSBS093537@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Mon, 15 Jan 2024 09:37:48 -0700 Message-ID: Subject: Re: git: df834e06bbc7 - main - git-arc: Just strip escape sequences form arc log To: John Baldwin Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000003b3a8a060efea3a4" X-Rspamd-Queue-Id: 4TDHrF41B3z3wxK X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --0000000000003b3a8a060efea3a4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 15, 2024 at 9:30=E2=80=AFAM John Baldwin wrot= e: > On 1/14/24 6:24 PM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Ddf834e06bbc78c03cb6b35f074ae436= 73c9ce463 > > > > commit df834e06bbc78c03cb6b35f074ae43673c9ce463 > > Author: Warner Losh > > AuthorDate: 2024-01-15 02:22:04 +0000 > > Commit: Warner Losh > > CommitDate: 2024-01-15 02:23:45 +0000 > > > > git-arc: Just strip escape sequences form arc log > > > > Just strip escape sequences and Warning: lines from 'arc list' > output. I > > upgraded and they changed and git arc list broke. This restores it= s > > functionality. > > > > Note: jhb didn't like this, so if others object, I'll fix... > > > > Sponsored by: Netflix > > Reviewed by: markj > > Differential Revision: https://reviews.freebsd.org/D36553 > > Namely, it breaks the color output for reviews in different states, so > Needs Review > shows up as purple, Approved as green, etc. If you find the color output > useful > you'll have to revert this locally. > > Also, your last update in the review said that git arc was no longer > broken for you > back in May implying this commit wasn't needed for git arc to work for yo= u? > Yes and no. I was mistaken. This change is still needed, but its scope can be reduced. The trouble is that it's at the first for the other things I committed and getting it out of the way was a pain (I tried). Since I didn't want to delay things any further, I went ahead and committed and thought I'd fix stuff if there were objections.I'll do that now. Warner --0000000000003b3a8a060efea3a4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Jan 15, 2024 at 9:30=E2=80=AF= AM John Baldwin <jhb@freebsd.org&= gt; wrote:
On 1/= 14/24 6:24 PM, Warner Losh wrote:
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Ddf834e06bbc78c03cb6b35f074ae43673c9ce463<= /a>
>
> commit df834e06bbc78c03cb6b35f074ae43673c9ce463
> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2024-01-15 02:22:04 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-01-15 02:23:45 +0000
>
>=C2=A0 =C2=A0 =C2=A0 git-arc: Just strip escape sequences form arc log<= br> >=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Just strip escape sequences and Warning: lines fro= m 'arc list' output. I
>=C2=A0 =C2=A0 =C2=A0 upgraded and they changed and git arc list broke. = This restores its
>=C2=A0 =C2=A0 =C2=A0 functionality.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Note: jhb didn't like this, so if others objec= t, I'll fix...
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0Netflix
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 markj
>=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 https://revi= ews.freebsd.org/D36553

Namely, it breaks the color output for reviews in different states, so Need= s Review
shows up as purple, Approved as green, etc.=C2=A0 If you find the color out= put useful
you'll have to revert this locally.

Also, your last update in the review said that git arc was no longer broken= for you
back in May implying this commit wasn't needed for git arc to work for = you?

Yes and no. I was mistaken. This c= hange is still needed, but its scope can be reduced.
The trouble = is that it's at the first for the other things I committed and getting = it out of the
way was a pain (I tried). Since I didn't want t= o delay things any further, I went ahead and
committed and though= t I'd fix stuff if there were objections.I'll do that now.

Warner
--0000000000003b3a8a060efea3a4--