Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jan 2020 19:19:56 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r357222 - projects/clang1000-import/libexec/rbootd
Message-ID:  <202001281919.00SJJuhL050310@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Tue Jan 28 19:19:55 2020
New Revision: 357222
URL: https://svnweb.freebsd.org/changeset/base/357222

Log:
  Fix the following -Werror warning from clang 10.0.0 in rbootd:
  
  libexec/rbootd/rmpproto.c:335:49: error: multiple unsequenced modifications to 'filename' [-Werror,-Wunsequenced]
          filename = (filename = strrchr(filepath,'/'))? ++filename: filepath;
                   ~                                     ^
  
  MFC after:	3 days

Modified:
  projects/clang1000-import/libexec/rbootd/rmpproto.c

Modified: projects/clang1000-import/libexec/rbootd/rmpproto.c
==============================================================================
--- projects/clang1000-import/libexec/rbootd/rmpproto.c	Tue Jan 28 19:07:37 2020	(r357221)
+++ projects/clang1000-import/libexec/rbootd/rmpproto.c	Tue Jan 28 19:19:55 2020	(r357222)
@@ -332,7 +332,8 @@ SendBootRepl(struct rmp_packet *req, RMPCONN *rconn, c
 	 *  stripped file name and spoof the client into thinking that it
 	 *  really got what it wanted.
 	 */
-	filename = (filename = strrchr(filepath,'/'))? ++filename: filepath;
+	filename = strrchr(filepath,'/');
+	filename = filename? filename + 1: filepath;
 
 	/*
 	 *  Check that this is a valid boot file name.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202001281919.00SJJuhL050310>