From owner-freebsd-security  Thu Dec  7  6:58:19 2000
From owner-freebsd-security@FreeBSD.ORG  Thu Dec  7 06:58:17 2000
Return-Path: <owner-freebsd-security@FreeBSD.ORG>
Delivered-To: freebsd-security@freebsd.org
Received: from innocence.interface-business.de (innocence.interface-business.de [193.101.57.202])
	by hub.freebsd.org (Postfix) with ESMTP id E805537B400
	for <freebsd-security@freebsd.org>; Thu,  7 Dec 2000 06:58:15 -0800 (PST)
Received: from interface-business.de (uucp@localhost)
          by innocence.interface-business.de with UUCP id PAA35420
          for freebsd-security@freebsd.org; Thu, 7 Dec 2000 15:58:14 +0100 (CET)
Received: (from j@localhost)
          by B7173150.deutschepost.de id PAA12713
          for freebsd-security@freebsd.org; Thu, 7 Dec 2000 15:57:50 +0100 (CET)
Date: Thu, 7 Dec 2000 15:57:50 +0100
From: J Wunsch <j@ida.interface-business.de>
To: freebsd-security@freebsd.org
Subject: Re: Please review a change to lock(1)
Message-ID: <20001207155750.E4709@B7173150.DeutschePost.de>
Reply-To: Joerg Wunsch <joerg_wunsch@interface-business.de>
References: <20001207115835.V4709@B7173150.DeutschePost.de> <Pine.BSF.4.10.10012070825530.50115-100000@bsdie.rwsystems.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.95.4i
In-Reply-To: <Pine.BSF.4.10.10012070825530.50115-100000@bsdie.rwsystems.net>; from James Wyatt on Thu, Dec 07, 2000 at 08:29:03AM -0600
X-Phone: +49-351-31809-14
X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F  93 21 E0 7D F9 12 D6 4E
Organization: interface business GmbH, Dresden
Sender: j@interface-business.de
Sender: owner-freebsd-security@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

As James Wyatt wrote:

> Maybe you could see if it's PPID becomes 1 as init inherits it as an
> orphan from the dead parent process. I would *definately* syslog the error
> as a simple error *could* be an attempt to trick lock. Some programs
> deserve paranoia due to their use and level of users' blind trust. - Jy@

OK, point taken, new suggestion.

(Btw., please leave me in the Cc list when replying, i'm not subscribed
to -security.)

Index: lock.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/lock/lock.c,v
retrieving revision 1.8
diff -u -r1.8 lock.c
--- lock.c	1999/10/12 13:53:30	1.8
+++ lock.c	2000/12/07 14:54:48
@@ -61,6 +61,7 @@
 #include <sys/time.h>
 #include <sys/signal.h>
 #include <err.h>
+#include <errno.h>
 #include <ctype.h>
 #include <pwd.h>
 #include <sgtty.h>
@@ -189,7 +190,15 @@
 
 	for (;;) {
 		(void)printf("Key: ");
+		errno = 0;
 		if (!fgets(s, sizeof(s), stdin)) {
+			if (errno == EIO && getppid() == 1) {
+				/* Our terminal is gone; good-bye. */
+				syslog(LOG_NOTICE,
+			"exiting due to IO error on terminal (UID %d@%s on %s)",
+					getuid(), ttynam, hostname);
+				exit(1);
+			}
 			clearerr(stdin);
 			hi();
 			continue;

-- 
Joerg Wunsch             NIC hdl: JW11-RIPE             On the air: DL8DTL
See http://www.interface-business.de/~j/ for more information.

Some addresses in the headers might be wrong (sorry - I'm not the admin here).


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message