From owner-freebsd-threads@FreeBSD.ORG Thu Apr 8 14:25:42 2004 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB09416A4CE for ; Thu, 8 Apr 2004 14:25:42 -0700 (PDT) Received: from dan.emsphone.com (dan.emsphone.com [199.67.51.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79FEF43D39 for ; Thu, 8 Apr 2004 14:25:42 -0700 (PDT) (envelope-from dan@dan.emsphone.com) Received: (from dan@localhost) by dan.emsphone.com (8.12.10/8.12.10) id i38LPfdH077068; Thu, 8 Apr 2004 16:25:41 -0500 (CDT) (envelope-from dan) Date: Thu, 8 Apr 2004 16:25:41 -0500 From: Dan Nelson To: Daniel Eischen Message-ID: <20040408212541.GE8182@dan.emsphone.com> References: <20040408150553.GA8182@dan.emsphone.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-OS: FreeBSD 5.2-CURRENT X-message-flag: Outlook Error User-Agent: Mutt/1.5.6i cc: freebsd-threads@freebsd.org Subject: Re: missing error-checking in libpthread? X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2004 21:25:43 -0000 In the last episode (Apr 08), Daniel Eischen said: > On Thu, 8 Apr 2004, Dan Nelson wrote: > > I'm seeing the following stack trace in a testsuite for a threaded > > program. At the time I generated the coredump, the process was in > > a loop calling kse_release({0,1000000}) about 1.5 million > > times/sec, every call returning EINVAL. > > Can you try this patch? > > Index: thr_kern.c > =================================================================== > RCS file: /opt/FreeBSD/cvs/src/lib/libpthread/thread/thr_kern.c,v That seems to fix my problem! I think it'd be nice if those kse_releases() were error-checked though, just to keep something similar from happening again. -- Dan Nelson dnelson@allantgroup.com