Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 1 Nov 2022 10:46:36 -0700
From:      Yuri <yuri@FreeBSD.org>
To:        Adam Weinberger <adamw@adamw.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: a5aaa84fcc6d - main - devel/msgpack-cxx: Add missing dependency devel/boost-libs
Message-ID:  <fdb1c6a5-a741-c706-afea-db72836da0c3@tsoft.com>
In-Reply-To: <CAP7rwcgEvsBU=8sPgh5xiHy2XU_G8_F_Do_jXNPgbi4QLacyFA@mail.gmail.com>
References:  <202211011632.2A1GW36v086037@gitrepo.freebsd.org> <CAP7rwcgEvsBU=8sPgh5xiHy2XU_G8_F_Do_jXNPgbi4QLacyFA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help 
This is a multi-part message in MIME format.
--------------XSAyBxNuqUKQhYdhcjgQy5kP
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Adam,


On 11/1/22 10:28, Adam Weinberger wrote:
>
> This was intentional; see the CMAKE_OFF. Boost is no longer required, 
> and the port is using the non-boost version.
>

Now I see this CMAKE_OFF item.

However, upon a deeper look it doesn't appear that disabling Boost is 
done cleanly in the installed code.

For example, the installed file msgpack/v1/adaptor/cpp11/chrono.hpp 
includes boost/numeric/conversion/cast.hpp without being conditional on 
MSGPACK_USE_BOOST.

I'll report this upstream.


I reverted it anyways.



Thanks,

Yuri

--------------XSAyBxNuqUKQhYdhcjgQy5kP
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hi Adam,</div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">On 11/1/22 10:28, Adam Weinberger
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAP7rwcgEvsBU=8sPgh5xiHy2XU_G8_F_Do_jXNPgbi4QLacyFA@mail.gmail.com">
      <div><br>
      </div>
      <div style="font-family:arial,sans-serif" class="gmail_default">This
        was intentional; see the CMAKE_OFF. Boost is no longer required,
        and the port is using the non-boost version.</div>
      <div style="font-family:arial,sans-serif" class="gmail_default"><br>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>Now I see this CMAKE_OFF item.</p>
    <p>However, upon a deeper look it doesn't appear that disabling
      Boost is done cleanly in the installed code.</p>
    <p>For example, the installed file
      msgpack/v1/adaptor/cpp11/chrono.hpp includes
      boost/numeric/conversion/cast.hpp without being conditional on
      MSGPACK_USE_BOOST.</p>
    <p>I'll report this upstream.<br>
    </p>
    <p><br>
    </p>
    <p>I reverted it anyways.<br>
    </p>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>Thanks,<br>
    </p>
    <p>Yuri<br>
    </p>
  </body>
</html>

--------------XSAyBxNuqUKQhYdhcjgQy5kP--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fdb1c6a5-a741-c706-afea-db72836da0c3>