From owner-svn-ports-all@freebsd.org Sat Nov 23 12:22:56 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 69E0D1B41CC; Sat, 23 Nov 2019 12:22:56 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Ksrb23mVz40cV; Sat, 23 Nov 2019 12:22:54 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-wr1-f65.google.com with SMTP id i12so11778636wrn.11; Sat, 23 Nov 2019 04:22:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ZsLcPwhaV98b3H016lsrJqrhUQDGvA9O4MKUYqIjgd8=; b=fb2VSrPE56cJrackLSwVWiuukw4/H7rnN3bMvKbr3KU6I8Y0BLWYa0y+aYHqinLfmu cSQmYKdMxlP5GfA335bLtL1GF9XeIo5NH4rbpQbxt/Pd45Uya1dghUxZfMKchyjoNx4T O9QUhZNwhffXpWahDi1XNZpMWUzyLKx1/6vYJtYsAwKzwi9N7pwaq8vLcc1rFqs9EsSq 8BFsEtjEjKppoVXwfxOqmK9b9Hk2qmYe91fD2BL1eUck3kWxYBwfrMstczKgTssmZL5g 4tfZGXyQKbJrh+AYEdlb5qG0L6MbAglTC8tWKsTS9pjzriZLXDZo2lTAiyq8rHCNM212 itOA== X-Gm-Message-State: APjAAAXmwcI/t6MdRaxorl5dBc9GaaPdXumhMwVxTRheOGAqqzyTnDpP uR/iP2VUJljwa0+Tad3+4adKLZ54thQ= X-Google-Smtp-Source: APXvYqw5wsGu8Hfbi1N3scUhAIZ4kBCq6BY8FZV2ziHf2GQ3wVoo5PGtzrBKYDD6ccW6l8sAQfrvkw== X-Received: by 2002:adf:dc0a:: with SMTP id t10mr21520544wri.138.1574511773334; Sat, 23 Nov 2019 04:22:53 -0800 (PST) Received: from [192.168.178.113] (ip5f5bd707.dynamic.kabel-deutschland.de. [95.91.215.7]) by smtp.gmail.com with ESMTPSA id v184sm1756095wme.31.2019.11.23.04.22.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Nov 2019 04:22:52 -0800 (PST) Subject: Re: svn commit: r516987 - in head: net/remotebox net/remotebox/files x11/gcb x11/gcb/files To: Max Brazhnikov Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201911071707.xA7H7Pj0023431@repo.freebsd.org> <5176694.8gLySxXtyI@mercury.ph.man.ac.uk> From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-ID: <29071699-189d-71c4-31ef-406a1ee43f46@FreeBSD.org> Date: Sat, 23 Nov 2019 13:22:51 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <5176694.8gLySxXtyI@mercury.ph.man.ac.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: 47Ksrb23mVz40cV X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.221.65 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-4.93 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.93)[ip: (-9.45), ipnet: 209.85.128.0/17(-3.17), asn: 15169(-1.96), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[65.221.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[65.221.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[7.215.91.95.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Nov 2019 12:22:56 -0000 Hi, On 11/7/19 9:24 PM, Max Brazhnikov wrote: > On Thu, 7 Nov 2019 17:07:25 +0000 (UTC) Mateusz Piotrowski wrote: >> Author: 0mp >> Date: Thu Nov 7 17:07:24 2019 >> New Revision: 516987 >> URL: https://svnweb.freebsd.org/changeset/ports/516987 >> >> Log: >> Remove suffix from Icon key in desktop entries >> >> Suffixes, like .png, are not part of the specification. Although many >> ports like misc/xfce4-appfinder have implemented workarounds for it, >> ports like x11/rofi are missing icons due to a suffix being present in the >> Icon key. >> >> References: >> - https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html >> - https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#icon_lookup >> >> Approved by: portmgr (blanket, runtime fixes) >> >> Modified: >> head/net/remotebox/Makefile >> head/net/remotebox/files/remotebox.desktop >> head/x11/gcb/Makefile >> head/x11/gcb/files/gcb.desktop (Snipped.) > These files look simple. I think they can be removed and replaced with DESKTOP_ENTRIES. Nice idea! I've done that for net/remotebox in r517851. I am not touching x11/gcb at the moment because it was broken the last time I checked. Cheers, Mateusz