From owner-freebsd-usb@FreeBSD.ORG  Mon Nov  1 21:05:18 2004
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8E74B16A4CF; Mon,  1 Nov 2004 21:05:18 +0000 (GMT)
Received: from avscan1.sentex.ca (avscan1.sentex.ca [199.212.134.11])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 097E143D41; Mon,  1 Nov 2004 21:05:16 +0000 (GMT)
	(envelope-from keith@sentex.net)
Received: from localhost (localhost.sentex.ca [127.0.0.1])
	by avscan1.sentex.ca (8.12.11/8.12.11) with ESMTP id iA1L5F9A038626;
	Mon, 1 Nov 2004 16:05:15 -0500 (EST)
	(envelope-from keith@sentex.net)
Received: from avscan1.sentex.ca ([127.0.0.1])
 by localhost (avscan1.sentex.ca [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 38278-05; Mon,  1 Nov 2004 16:05:14 -0500 (EST)
Received: from lava.sentex.ca (pyroxene.sentex.ca [199.212.134.18])
	by avscan1.sentex.ca (8.12.11/8.12.11) with ESMTP id iA1L5Eoi038604;
	Mon, 1 Nov 2004 16:05:14 -0500 (EST)
	(envelope-from keith@sentex.net)
Received: from lapisjr (jegmadar.sentex.ca [192.168.43.205] (may be forged))
	by lava.sentex.ca (8.12.11/8.12.11) with ESMTP id iA1L589N095730;
	Mon, 1 Nov 2004 16:05:08 -0500 (EST)
	(envelope-from keith@sentex.net)
From: "Keith Winter" <keith@sentex.net>
To: <freebsd-gnats-submit@FreeBSD.org>, <freebsd-dev@sentex.net>
Date: Mon, 1 Nov 2004 16:04:59 -0500
Message-ID: <008401c4c056$7294a080$cd2ba8c0@lapisjr>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook, Build 10.0.6626
Importance: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180
X-Virus-Scanned: by amavisd-new
X-Virus-Scanned: by amavisd-new at avscan1b
cc: freebsd-usb@FreeBSD.org
Subject: Re: kern/72935: sio tty and uhid tty (perhaps others) stomp on each
	other leading to kernel data corruption and a panic
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Nov 2004 21:05:18 -0000

We are trying to generalize the fix for this.  It was pointed out by Julian Elischer that this prevents bio devices from trampling
on tty devices, but not vice versa.

Would the following be a more general solution for uhid devices?

        {
                int s = splhigh();
                tty_imask |= bio_imask;
                bio_imask |= tty_imask;
                update_intr_masks();
                splx( s );
        }

The approach is similar to what was done for ppp/slip.

-- KDW