From nobody Mon Sep 18 22:15:12 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RqJy86Cqjz4tqng for ; Mon, 18 Sep 2023 22:15:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RqJy82lj0z3KTy for ; Mon, 18 Sep 2023 22:15:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695075312; a=rsa-sha256; cv=none; b=nq6atznyHOAUMAWHA61mY+jjv/Qb9yGePXwd8KA53EWVE+suyVBNWaTCeGLeluaDueMUyq mtBBjiPrJ9gCf3pkNMU1MhbgZx2Mvf4iVEPSj45zaaqxs0EcBci6yLlveK3LxeePOoKz9C JhCpFraFGGf3/nOOu+VbHML1cMSZ9j39zMsZqqp3OZdodN8+3o7inEjfNz4xuAVv/UOoVC rFEhRKO8Es7lCMMKSSjGA6w0ht80Jdv2XdQEIOijM7NSuxOJ6HdbG42sn2eTt4knJXGkBJ NUCBfiyYNl79tvd+vjjiErKFPeMU310iRmdcZ6kqorsAsbXgsPA54V+FnVPTPg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695075312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=twodfSnC17OAjW4IJBFJErgeue+V4DfgcT98qfWoFfs=; b=bsJ7qithRy/6JZf9dE23GcUBrzbPH3uSJkmltlz27PsIG/Fpv1KI3wE/VsabGmRIpxiWl0 EOS/jaHiKkjhq6hBzl8qMQpypd+u3eEfwYW6HV1Ku907f8CW9bUdQ3RelcmJCnzq+l3hod v+O9u4hZV+LsBwMU/UeaapoMYt94nnJRSoWX6zkP8GNf1FuvtBEnNF8nVlegrqJtgr2ooI 3HVijvrj2eTXH3ap0LX1L4dxIZVHUC+PeHU1qK3TZj053EPi1VS/E++WXn5aY+3bA4wJlA dBHOLXbcWrw/nvcU7zo6Ku0CYxnFoIOE6y8gZClnlmqiL4lQpLbpssS7mEgduQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RqJy81rsRzp2K for ; Mon, 18 Sep 2023 22:15:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38IMFCgi002090 for ; Mon, 18 Sep 2023 22:15:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38IMFCNx002089 for bugs@FreeBSD.org; Mon, 18 Sep 2023 22:15:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273418] [panic] Repeating kernel panic on open(/dev/console) Date: Mon, 18 Sep 2023 22:15:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jah@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273418 --- Comment #18 from Jason A. Harmening --- Shouldn't the asserts in my proposed patch already accomplish what we need here? It may not be truly necessary to add a new flag solely tracking active list membership (vs. CDP_ACTIVE), but it seemed worth doing given that a devnode= can be marked inactive while still on cdevp_list. Beyond that, the patch alrea= dy has: 1) An assert that the node isn't on cdevp_list when devfs_free() is called, which is probably the critical case here due to incorrect (un)referencing. 2) Asserts in the other places that add or remove from cdevp_list, to catch other incorrect behavior e.g. trying add a node to the tail of the list when it's already elsewhere on the list. --=20 You are receiving this mail because: You are the assignee for the bug.=