Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 May 2018 00:10:34 +0200
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Craig Leres <leres@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r468990 - in head/devel: . xtensa-esp32-elf
Message-ID:  <20180503221034.rbda7h3z54eptzh7@atuin.in.mat.cc>
In-Reply-To: <201805032150.w43LoL9p036469@repo.freebsd.org>
References:  <201805032150.w43LoL9p036469@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--p6jexd6xcqjxxwjr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 03, 2018 at 09:50:21PM +0000, Craig Leres wrote:
> +pre-configure:
> +	cd ${BUILD_WRKSRC} && ./bootstrap
> +	${PRINTF} "#!/bin/sh\necho '${SUBDIR:tl}-${TAGNAME}'\n" > \
> +	    ${BUILD_WRKSRC}/version.sh
> +	${CHMOD} -w+x ${BUILD_WRKSRC}/version.sh
> +
> +do-configure:
> +	cd ${BUILD_WRKSRC} && \
> +	    ./configure --enable-local --with-grep=3D${LOCALBASE}/bin/grep

Please fold pre-configure into do-configure.

> +pre-build:
> +	cd ${BUILD_WRKSRC} && \
> +	    ${SETENV} -uMAKELEVEL -uMAKEFLAGS -u.MAKE.LEVEL.ENV \
> +	    ${MAKE_CMD} install && ${SETENV} ${BUILD_ENV} ./ct-ng ${PORTNAME}
> +
> +do-build:
> +	cd ${BUILD_WRKSRC} && ${SETENV} ${BUILD_ENV} ./ct-ng build
> +
> +post-build:
> +	cd ${BUILD_WRKSRC}/builds/${PORTNAME} && \
> +	    ${RM} build.log.bz2 lib/charset.alias

Please fold all those build targets into only do-build.

--=20
Mathieu Arnold

--p6jexd6xcqjxxwjr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAABCgBmBQJa64jaXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IRRsQAKDEaX3gzEAz/aO29yHKR1DC
uNq1GVG/cjjOS6lVhL8Hh0+MwcWkSjZ34P25CD4+EaNR2O/poG6aRTsZcRhER31Y
falD58K21CYrKDWlzPrO65v+4TvsBKiOZiM/mgQFK9WSYpcC4o0KIkyryw3GvXMS
1nro4xpErXZPzzlCYlUYi+CHEfO0oyqKvZZR8DuxbwQKk+65SM9T9KEhDRKfQd/S
0mYM+/nclmsROU+Bi+xjNGyfk1RGV+nf6VX5ngJWDrhMMIQmkamyQA6lMuThWlw6
Pt1IexZHV7jT9ujh3hPuhEbE/jVcnGS3dE4DneLMCeDAipP23l0PS+Y5fW/h8sWF
RPUmn26hE7uJzN2jpAxXBSjzcs1hLF4tqTwMLBjmbIKpe9kCzb6/YPLeCfmypbFm
u6GmH8bHcl+3pExJAMLn7+T95dqJdzB5qLj8V7gpqIfEKwdt+RIutt0d59rPLeug
Lbsm0PBWDW2fsYfiAzdRqlQzUkf6p7mWXkLYdWkMMpg/WF0VJXQtbD1Lvvf7bKMi
yG9APlT3HprBLBpA54Kq9a7tghJCfw5GpLcVu0TlobnJ0Yf6kkQlWED/l+eun7uN
dnNA50UVGa5ieCTPnK3KB8mouqTsyFpqlnakxPP7n0a+CW1wU6SkhMwLzChLy+Pn
pq9ggnRz3mvsk4Sftue+
=1Jg6
-----END PGP SIGNATURE-----

--p6jexd6xcqjxxwjr--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180503221034.rbda7h3z54eptzh7>