Date: Fri, 28 Oct 2016 08:13:58 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 213845] [PATCH] bxe(4) boots with no capabilities enabled Message-ID: <bug-213845-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213845 Bug ID: 213845 Summary: [PATCH] bxe(4) boots with no capabilities enabled Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: pherman@frenchfries.net Keywords: patch bxe cards boot with no hardware capabilities (i.e. RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4...) enable= d. "ifconfig -m bxe0" correctly displays what NIC is capable of, but no options are enabled. This is a problem because, for example, "ifconfig vlanmtu" is not allowed t= o be changed by the driver and consequently all cloned vlan devices end up with = an MTU of 1496 by default. The bug was introduced when the driver was updated= to use if_setcapabilities(). CURRENT is also affected. 10 isn't. Suggested patch against 11.0-STABLE bel= ow. bxe0: <QLogic NetXtreme II BCM57810 10GbE (B0) BXE v:1.78.89 FreeBSD rt2-gerdc1.cgn.cleverbridge.com 11.0-STABLE FreeBSD 11.0-STABLE #1 r308000M: Thu Oct 27 17:29:07 CEST 2016=20=20=20=20 root@rt2-gerdc1.cgn.cleverbridge.com:/usr/obj/usr/src/sys/rt2-gerdc1 amd64 Index: sys/dev/bxe/bxe.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/bxe/bxe.c (revision 308000) +++ sys/dev/bxe/bxe.c (working copy) @@ -12691,6 +12691,7 @@ IFCAP_WOL_MAGIC); #endif if_setcapabilitiesbit(ifp, capabilities, 0); /* XXX */ + if_setcapenable(ifp, if_getcapabilities(ifp)); if_setbaudrate(ifp, IF_Gbps(10)); /* XXX */ if_setsendqlen(ifp, sc->tx_ring_size); --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-213845-8>