From owner-freebsd-pf@FreeBSD.ORG  Wed Feb 25 14:10:06 2009
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 09064106564A
	for <freebsd-pf@freebsd.org>; Wed, 25 Feb 2009 14:10:06 +0000 (UTC)
	(envelope-from artis.caune@gmail.com)
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156])
	by mx1.freebsd.org (Postfix) with ESMTP id 8E34D8FC1D
	for <freebsd-pf@freebsd.org>; Wed, 25 Feb 2009 14:10:05 +0000 (UTC)
	(envelope-from artis.caune@gmail.com)
Received: by fg-out-1718.google.com with SMTP id l26so241821fgb.35
	for <freebsd-pf@freebsd.org>; Wed, 25 Feb 2009 06:10:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=sm5+3/VfNiZgsP2+QlW772FxF/L9DIhxOcQlm80jSWA=;
	b=fzAlI1gdfxzNb4EJjnghn9RuEmGlVHivBonnywqKbz7Ra1zbTpyPF5IYTyHgifUsn+
	fJd3HjVKN6gnP56KdEhPT/Ns3uEcMxLDSvd1NduKLqHYdkUBe1DsgwDDPrRlQa2hihN/
	UO6cvIYsaKqy31PZ7wGiqb7m//p9Wv6Sy8WQ8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	b=hHjKXOWN4Oz7rBQMVZT9v4xJIZ8OxvOAOdJmbK8hu38QpyAIk4sSj5u16EjxvAQo0Q
	2kCYswNF9VQStH2j3Y16GPpIcdWfCxcmOXykj/um5opIOU+dGxMojlzt5tBlvhcUAk8y
	/NEZad57/+WiKhtWVMhM2HXOAOeZom19Z/iIU=
MIME-Version: 1.0
Received: by 10.86.95.8 with SMTP id s8mr826251fgb.16.1235571004455; Wed, 25 
	Feb 2009 06:10:04 -0800 (PST)
In-Reply-To: <200902251442.43794.max@love2party.net>
References: <9e20d71e0902250435y6e090fb0rc138233242fe7d60@mail.gmail.com>
	<200902251442.43794.max@love2party.net>
Date: Wed, 25 Feb 2009 16:10:04 +0200
Message-ID: <9e20d71e0902250610l62a42a99t5b9683aefb08c7cf@mail.gmail.com>
From: Artis Caune <artis.caune@gmail.com>
To: Max Laier <max@love2party.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: beck@openbsd.org, samm@os2.kiev.ua, freebsd-pf@freebsd.org
Subject: Re: openbsd spamd is leaking memory?
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
	\(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2009 14:10:06 -0000

2009/2/25 Max Laier <max@love2party.net>:
> Hello Artis,
>
> looks like a valid catch to me.  I'm CC'ing the upstream maintainer (Bob,
> that's you, right?)  From a quick glance there is also a minor leak in
> readsuffixlists in the goto bad case.
>


I'm running spamd with this patch more than 2h and no leaks :)



--- grey.c.orig 2008-12-07 23:12:52.000000000 +0200
+++ grey.c      2009-02-25 15:22:48.000000000 +0200
@@ -512,7 +512,8 @@
               dbc->act = 0;
               dbc->dsiz = 0;
               SLIST_REMOVE_HEAD(&db_changes, entry);
-
+        free(dbc);
+        dbc = NULL;
       }
       return(ret);
 }






-- 
regards,
Artis Caune

<----. CCNA | BSDA
<----|====================
<----' didii FreeBSD