From owner-svn-src-all@freebsd.org Sun Jul 29 19:33:28 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E414910610F2; Sun, 29 Jul 2018 19:33:27 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E94776822; Sun, 29 Jul 2018 19:33:27 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.4] (c-71-198-162-232.hsd1.ca.comcast.net [71.198.162.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id BAAA223D00; Sun, 29 Jul 2018 19:33:26 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/10.f.0.180709 Date: Sun, 29 Jul 2018 12:33:23 -0700 Subject: Re: svn commit: r336526 - head From: Ravi Pokala To: Will Andrews CC: Ian Lepore , "src-committers@FreeBSD.org" , , Message-ID: <4BC0DA67-495D-4029-A9CA-18407A1B9746@panasas.com> Thread-Topic: svn commit: r336526 - head References: <201807200044.w6K0i4QQ079894@repo.freebsd.org> <1532108303.1344.57.camel@freebsd.org> <67239C31-11DA-43E0-B282-5AE894C2B0CB@panasas.com> <0178BAB4-FEFB-473B-9245-3F11ABDA8C09@freebsd.org> In-Reply-To: Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 19:33:28 -0000 -----Original Message----- From: Will Andrews Date: 2018-07-28, Saturday at 18:44 To: Ravi Pokala Cc: Ian Lepore , "src-committers@FreeBSD.org" , , Subject: Re: svn commit: r336526 - head > Hi Ravi, > Thanks for taking an initial stab, I applied your patch and quickly realized the problem is deeper than it looks. This is because installworld and the second stage of mergemaster/etcupdate require the "pre" phase to take effect in their view of the system (specifically, the "ntpd" user must exist from their /etc/passwd, etc). For traditional upgrades, this occurs by simply rebooting. > > I've committed a revised version of your original patch, and have upgraded across this barrier using beinstall. Please give it a try and let me know how it goes. > > Thanks! > --Will. It worked! Thanks so much for following up on this, Will! :-) -Ravi (rpokala@) On Wed, Jul 25, 2018 at 11:28 PM, Ravi Pokala wrote: -----Original Message----- From: Ravi Pokala Date: 2018-07-20, Friday at 10:53 To: Ian Lepore , , , , Will Andrews Subject: Re: svn commit: r336526 - head > -----Original Message----- > From: on behalf of Ian Lepore > Date: 2018-07-20, Friday at 10:38 > To: Ravi Pokala , , , > Subject: Re: svn commit: r336526 - head > >> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote: >>> Hi Ian, >>> >>> -----Original Message----- >>> From: on behalf of Ian Lepore >>> Date: 2018-07-19, Thursday at 17:44 >>> To: , , >>> Subject: svn commit: r336526 - head >>> >>>> >>>> Author: ian >>>> Date: Fri Jul 20 00:44:04 2018 >>>> New Revision: 336526 >>>> URL: https://svnweb.freebsd.org/changeset/base/336526 >>>> >>>> Log: >>>> Add ntpd to the list of users/groups to check before installing. >>>> >>>> Modified: >>>> head/Makefile.inc1 >>> When trying to installworld: >>> >>> ERROR: Required ntpd user is missing, see /usr/src/UPDATING. >>> >>> But there is no UPDATING entry about this. (Also, shouldn't it be ${SRCTOP}/UPDATING?) >>> >>> Thanks, >>> >>> Ravi (rpokala@) >> >> I wondered about that too, when I accidentally stumbled across the >> CHECK_UIDS thing and realized I should add ntpd to it. I searched in >> UPDATING for some of the other things in the CHECK_UIDS list to see >> what had been said about such changes in the past, even searching >> through old-old svn history, and found nothing. >> >> I finally settled on the thought that the reference to UPDATING was to >> the stuff at the bottom that never changes. In particular to the >> section around line 1595 that documents the instalkernel, reboot, >> mergemaster, installworld sequence. The mergemaster part should take >> care of the new userid, I guess. >> >> -- Ian > > Interesting. I was attempting the install via the `beinstall.sh' script. CCing will@, since he wrote it. > > Thanks, > > Ravi (rpokala@) After some discussion on IRC, I created this patch to fix `beinstall.sh'. https://people.freebsd.org/~rpokala/beinstall.patch However, I'm a bit afraid of testing it, until someone who actually knows `etcupdate' and `mergemaster' can confirm that it won't blow up my box. :-) Can anyone take a look and assuage my fears? Thanks, Ravi (rpokala@)