Date: Sun, 29 Jul 2018 12:33:23 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Will Andrews <will@firepipe.net> Cc: Ian Lepore <ian@freebsd.org>, "src-committers@FreeBSD.org" <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r336526 - head Message-ID: <4BC0DA67-495D-4029-A9CA-18407A1B9746@panasas.com> In-Reply-To: <CADBaqmhL3%2B6yNapNegU4f3S9qraViKr727996hzuo-4_2NrsWw@mail.gmail.com> References: <201807200044.w6K0i4QQ079894@repo.freebsd.org> <FB81978A-C563-48E8-B259-A607126A7301@panasas.com> <1532108303.1344.57.camel@freebsd.org> <67239C31-11DA-43E0-B282-5AE894C2B0CB@panasas.com> <0178BAB4-FEFB-473B-9245-3F11ABDA8C09@freebsd.org> <CADBaqmhL3%2B6yNapNegU4f3S9qraViKr727996hzuo-4_2NrsWw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message----- From: Will Andrews <will@firepipe.net> Date: 2018-07-28, Saturday at 18:44 To: Ravi Pokala <rpokala@freebsd.org> Cc: Ian Lepore <ian@freebsd.org>, "src-committers@FreeBSD.org" <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r336526 - head > Hi Ravi, > Thanks for taking an initial stab, I applied your patch and quickly realized the problem is deeper than it looks. This is because installworld and the second stage of mergemaster/etcupdate require the "pre" phase to take effect in their view of the system (specifically, the "ntpd" user must exist from their /etc/passwd, etc). For traditional upgrades, this occurs by simply rebooting. > > I've committed a revised version of your original patch, and have upgraded across this barrier using beinstall. Please give it a try and let me know how it goes. > > Thanks! > --Will. It worked! Thanks so much for following up on this, Will! :-) -Ravi (rpokala@) On Wed, Jul 25, 2018 at 11:28 PM, Ravi Pokala <rpokala@freebsd.org> wrote: -----Original Message----- From: Ravi Pokala <rpokala@freebsd.org> Date: 2018-07-20, Friday at 10:53 To: Ian Lepore <ian@freebsd.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>, Will Andrews <will@FreeBSD.org> Subject: Re: svn commit: r336526 - head > -----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Ian Lepore <ian@freebsd.org> > Date: 2018-07-20, Friday at 10:38 > To: Ravi Pokala <rpokala@freebsd.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> > Subject: Re: svn commit: r336526 - head > >> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote: >>> Hi Ian, >>> >>> -----Original Message----- >>> From: <owner-src-committers@freebsd.org> on behalf of Ian Lepore >>> Date: 2018-07-19, Thursday at 17:44 >>> To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, >>> Subject: svn commit: r336526 - head >>> >>>> >>>> Author: ian >>>> Date: Fri Jul 20 00:44:04 2018 >>>> New Revision: 336526 >>>> URL: https://svnweb.freebsd.org/changeset/base/336526 >>>> >>>> Log: >>>> Add ntpd to the list of users/groups to check before installing. >>>> >>>> Modified: >>>> head/Makefile.inc1 >>> When trying to installworld: >>> >>> ERROR: Required ntpd user is missing, see /usr/src/UPDATING. >>> >>> But there is no UPDATING entry about this. (Also, shouldn't it be ${SRCTOP}/UPDATING?) >>> >>> Thanks, >>> >>> Ravi (rpokala@) >> >> I wondered about that too, when I accidentally stumbled across the >> CHECK_UIDS thing and realized I should add ntpd to it. I searched in >> UPDATING for some of the other things in the CHECK_UIDS list to see >> what had been said about such changes in the past, even searching >> through old-old svn history, and found nothing. >> >> I finally settled on the thought that the reference to UPDATING was to >> the stuff at the bottom that never changes. In particular to the >> section around line 1595 that documents the instalkernel, reboot, >> mergemaster, installworld sequence. The mergemaster part should take >> care of the new userid, I guess. >> >> -- Ian > > Interesting. I was attempting the install via the `beinstall.sh' script. CCing will@, since he wrote it. > > Thanks, > > Ravi (rpokala@) After some discussion on IRC, I created this patch to fix `beinstall.sh'. https://people.freebsd.org/~rpokala/beinstall.patch However, I'm a bit afraid of testing it, until someone who actually knows `etcupdate' and `mergemaster' can confirm that it won't blow up my box. :-) Can anyone take a look and assuage my fears? Thanks, Ravi (rpokala@)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BC0DA67-495D-4029-A9CA-18407A1B9746>