From owner-svn-ports-all@freebsd.org Thu Dec 14 20:53:29 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2966FE8F759; Thu, 14 Dec 2017 20:53:29 +0000 (UTC) (envelope-from dan@langille.org) Received: from clavin2.langille.org (clavin2.langille.org [199.233.228.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "clavin.langille.org", Issuer "BSD Cabal Headquarters" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0450579635; Thu, 14 Dec 2017 20:53:28 +0000 (UTC) (envelope-from dan@langille.org) Received: from (clavin2.int.langille.org (clavin2.int.unixathome.org [10.4.7.7]) (Authenticated sender: hidden) with ESMTPSA id 869C91FC61 ; Thu, 14 Dec 2017 20:53:21 +0000 (UTC) From: Dan Langille Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_67AB6987-BDA6-49F9-9545-5947498D58A7"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: svn commit: r456223 - in head/www: . Stikked Stikked/files Date: Thu, 14 Dec 2017 15:52:44 -0500 In-Reply-To: Cc: Dan Langille , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org To: Mathieu Arnold References: <201712131744.vBDHicEP086668@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.5.20) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 20:53:29 -0000 --Apple-Mail=_67AB6987-BDA6-49F9-9545-5947498D58A7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Dec 14, 2017, at 8:39 AM, Mathieu Arnold wrote: >=20 > Le 13/12/2017 =C3=A0 18:44, Dan Langille a =C3=A9crit : >> +WANT_PGSQL=3D client >> +WANT_SQLITE=3D client >> +WANT_MYSQL=3D client >=20 > What are those for ? You don't use them anywhere in the port. >=20 >> +PGSQL_USE=3D PHP=3Dpdo_pgsql >=20 > This is also never used. That's terrible. I think that is cruft leftover from when I was trying = to get this to work with PDO. I abandoned that when I realized it would also work = without. >=20 >> Added: head/www/Stikked/pkg-plist >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- /dev/null 00:00:00 1970 (empty, because file is newly = added) >> +++ head/www/Stikked/pkg-plist Wed Dec 13 17:44:38 2017 = (r456223) >> @@ -0,0 +1,3436 @@ >> +%%ETCDIR%%/stikked.php.sample >=20 > @sample ? A valid point, yes, that was my intent. >=20 >> + >=20 > Empty line I'd always left empty lines between different sections of pkg-plist for = readability. Gone. See https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D456372 >=20 -- Dan Langille - BSDCan / PGCon dan@langille.org --Apple-Mail=_67AB6987-BDA6-49F9-9545-5947498D58A7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQF8BAEBCgBmBQJaMuScXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDRUE3MDlFMjg3QjI3RkNCMjA0QzgxMDEy MTREM0Q1RDREQTc1RUQzAAoJECFNPV1Np17TYF4H/imn+bs39kiKsUydb5gcU0Kn VAdkgJoci4EIaN+5PvYkDn72k2LHwfBXi6x9kg9ajcbDN1P+DJBFA3eKrIwJBaLF E6az+gExyBCMWeK8TxkByXgkN2yBq8yPMu6bzYbuJjj7+qpCQ71/Gz29v1wcEAmv Dw6MXVMBQ0Uxxl1T8zoDvpK90CgXSlXHdSuT9jY6kD/5FqqKHWoIgPwuW3HUc4ni t6gHv/4YX+pohLL/+4eHMXyMeaVP4/BXI91Wq1QMN+EvNkFKxptUE27JfMOFYd/i TlM70ICR2YKkdxqZxppbeScFCTCrm7ydPb9D5PHTaVzqciR6OLVEwtyo+b4ea48= =cEhH -----END PGP SIGNATURE----- --Apple-Mail=_67AB6987-BDA6-49F9-9545-5947498D58A7--