From owner-freebsd-ports@freebsd.org Sun Jul 19 15:44:55 2015 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC8579A5A16 for ; Sun, 19 Jul 2015 15:44:55 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 8865B1D4D for ; Sun, 19 Jul 2015 15:44:55 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 857409A5A13; Sun, 19 Jul 2015 15:44:55 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6B2C39A5A12 for ; Sun, 19 Jul 2015 15:44:55 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E36321D4B; Sun, 19 Jul 2015 15:44:54 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by widic2 with SMTP id ic2so70843013wid.0; Sun, 19 Jul 2015 08:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ubj6XXMr9qfFiBiQRDqK0WS9jfr75rqzXV/BmvR+YSQ=; b=E8oR57RksiDKIH+17BVg9OCy0EZlO9vxHTREOHx1joRpZlWWwPZe+7kO1O1eehLX2k K2fPBeN7OovIIHUYfrB9Hjbsq3iH71R6DA8DK6UE3Lv1kw8uXk57SCd84fJowrcesaqR Re3q17R+1i2pxpLT0LrSQzizYpJ0b8pIFsUXjKrmZVxoDniMle+F0mW76zQQlp0hK5u+ cgrUphoNuZy6T9U1/ORfFnvOD6l9xc5RGmEoAsX1YJRa1G02fh1xJ1Q092RY1yv3ecKA b9StwD5rI4ZdQ/PadIowEGebDtQ86O95OgE7YAqqXaM+z92fo5gNSQmsyghKaKdWIOnm Eduw== X-Received: by 10.181.13.36 with SMTP id ev4mr13462959wid.65.1437320692598; Sun, 19 Jul 2015 08:44:52 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id d17sm27641033wjs.32.2015.07.19.08.44.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jul 2015 08:44:51 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 19 Jul 2015 17:44:49 +0200 From: Baptiste Daroussin To: Michelle Sullivan Cc: Dimitry Andric , "ports@freebsd.org" Subject: Re: Self committing... allowed or not? Message-ID: <20150719154449.GD50618@ivaldir.etoilebsd.net> References: <55AB91ED.3080908@sorbs.net> <9917125A-6342-4F62-B374-E4F456EDC015@FreeBSD.org> <55ABBFEC.60302@sorbs.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oj4kGyHlBMXGt3Le" Content-Disposition: inline In-Reply-To: <55ABBFEC.60302@sorbs.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2015 15:44:55 -0000 --oj4kGyHlBMXGt3Le Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 19, 2015 at 05:19:08PM +0200, Michelle Sullivan wrote: > Dimitry Andric wrote: > > On 19 Jul 2015, at 14:02, Michelle Sullivan wrote: > > =20 > >> please correct me if I'm wrong but isn't self committing (those with t= he > >> commit bit committing their own patches without QA/review/adding > >> patchfiles to the PR) against the rules?... or is it just a free-for-a= ll > >> now? > >> =20 > > > > If they are the maintainer, it is OK by definition. Otherwise, approval > > from either the maintainer or portmgr@ is needed. > > > > However, a number of people are on vacation, and they have notified > > other developers that is OK to fix their ports while they are away. > > Within reason, of course. :-) > > > > In any case, which specific ports are you worried about? > > > > -Dimitry > > > > =20 > Here's the case and the three referenced commits: >=20 > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D199265 >=20 > And I know the top-level dependency will now break other things because > of a minor detail that the committer did not take into account... That > said I don't know if any other dependencies on it exist (so therefore it > might not break anything else - however I am fairly sure it wasn't > checked by the committer because of the speed and absoluteness of the > change) because I don't need it/use it myself... but that is not the > point. I was 'just lucky' to come across this change process as I was > not looking for anything, just happened to be in the right place at the > right time to see it, and considering the hoops use plebs (those without > the commit bit) have to jump through I thought it was rather ironic that > 3 separate ports were changed, no testing was recorded in the PR as we > the plebs are required to do, no patches uploaded as we the plebs have > to do and no review as we the plebs have to have...=20 >=20 do you appear to know the said ports were broken (segfault) at startup beca= use of various libssl mixup, they have been tested and fixed. if another issue appears on those ports I will fix them. --oj4kGyHlBMXGt3Le Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlWrxfEACgkQ8kTtMUmk6Ez8IQCgvNiKn+QKiHy8S2l/Mp+LJ4vM SM4AmwbsCcZcVU7TfKRBkLpZf9ucUIfW =3P0b -----END PGP SIGNATURE----- --oj4kGyHlBMXGt3Le--