From owner-svn-src-all@freebsd.org Sat Jan 27 21:42:55 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 338FDEC44AD for ; Sat, 27 Jan 2018 21:42:55 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic317-49.consmr.mail.ne1.yahoo.com (sonic317-49.consmr.mail.ne1.yahoo.com [66.163.184.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C25A57B1F7 for ; Sat, 27 Jan 2018 21:42:54 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1517089373; bh=jrMjVTM3eLl7GnStzP93WgfhizL2k26xnU81s5pmKFQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=pg/vxXfyq3PiqNvIwFnE0ocO+vdH1/Ym5id171AMJ8bt81V3tiKFYjErVTFGbJ6wHplhetlwq+ShZ6GUQKdVaWwplu/vcD4jxdT2u6qT6EhXIypjupSJNBeVx9wUzzfvv32b4d3oRoN9goi/mtHxt3Z/1ASb1/fF+TrowxFO/KAd2t354hWPAAJ5Gec1str8JM/my9y+ggmFwjhRGxac6qURYAH9qvWmEeKyTdVD7CiqRjx6/axchMQ0V0vQg7UeLrA5axTmgEf20kyhc7QQTl9vwwfGqtVB9ixEhm8xYHbwR7YwuGAqT9qrvjGiT3PnKbBJlG3NeE9kTn0bQJ/9/g== X-YMail-OSG: YxxhL.UVM1nKh5Kz9zC67.xny6u21LwEcO6qnOTk5AoQLx0Vtj8XPtdDU9I_SYp hUsiVq1yzmPFnoZgyzZGkuA5ZLnD2gS.09OKUKUq0pVZi30DL_P6Z_.gxTfe2GAs1tsnpuj2bsXb wOPTmC0HY.DmxD4ABw_5L4RIWAtvjxA0Ete1Gi4T1tPRoRxdmQZmsqmFGU8Q1LIdsdTDwvjd_Con qmmS8iF9ZtgissxsKunlYyTFu0sXJceE4y3b2tulC7IhoMUBFbIkWPsCF1yrHOiYq_rsQldX46vD iwhXs9T049bpv9UH4Yq5sQsv1EG7R8685xZD.eTAHXUNjWNk97mQphEwjK1uX2ggBLy_MuNNYWFa CfAHKHyJyShmfVuCZwSZAhYGwcWDbe3OMW1gAo4hceGQuG5uon01VtoRfz6yL.oqqvpE556MV0Bb E2gtEFk8nXhZE7Fe7HW_9dfnByFaLFDqOusGgUggaULSPLoMqyAKyntsByb_XUITvO69FUuAp2Z8 t3pu2vg.47w-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Sat, 27 Jan 2018 21:42:53 +0000 Received: from smtp234.mail.ne1.yahoo.com (EHLO [192.168.0.8]) ([10.218.253.207]) by smtp414.mail.ne1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID f5cffd8c3486921569e85815f5fdbb6d; Sat, 27 Jan 2018 21:32:44 +0000 (UTC) Subject: Re: svn commit: r328486 - head/usr.bin/fortune/fortune To: cem@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801271743.w0RHh9io022619@repo.freebsd.org> From: Pedro Giffuni Message-ID: <1f1eb186-8f7b-6ec9-0970-d8b82b909e7b@FreeBSD.org> Date: Sat, 27 Jan 2018 16:32:42 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 21:42:55 -0000 Hi; On 01/27/18 14:56, Conrad Meyer wrote: > We can use 'true' and 'false' now. (style(9) also suggests using the > C99 names instead of TRUE/FALSE.) Yes, I noticed that change in DragonflyBSD but it is conceptually a different change and it deserves a different commit. Pedro. > On Sat, Jan 27, 2018 at 9:43 AM, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Sat Jan 27 17:43:09 2018 >> New Revision: 328486 >> URL: https://svnweb.freebsd.org/changeset/base/328486 >> >> Log: >> fortune(6): Fix gcc80 -Wbool-operation warnings. >> >> Hinted by: Dragonfly (git 4d1086765752f0569497d06460d95117c74f33ac) >> >> Modified: >> head/usr.bin/fortune/fortune/fortune.c >> >> Modified: head/usr.bin/fortune/fortune/fortune.c >> ============================================================================== >> --- head/usr.bin/fortune/fortune/fortune.c Sat Jan 27 17:24:59 2018 (r328485) >> +++ head/usr.bin/fortune/fortune/fortune.c Sat Jan 27 17:43:09 2018 (r328486) >> @@ -289,35 +289,35 @@ getargs(int argc, char *argv[]) >> #endif /* DEBUG */ >> switch(ch) { >> case 'a': /* any fortune */ >> - All_forts++; >> + All_forts = TRUE; >> break; >> #ifdef DEBUG >> case 'D': >> Debug++; >> break; >> #endif /* DEBUG */ >> - case 'e': >> - Equal_probs++; /* scatter un-allocted prob equally */ >> + case 'e': /* scatter un-allocted prob equally */ >> + Equal_probs = TRUE; >> break; >> case 'f': /* find fortune files */ >> - Find_files++; >> + Find_files = TRUE; >> break; >> case 'l': /* long ones only */ >> - Long_only++; >> + Long_only = TRUE; >> Short_only = FALSE; >> break; >> case 'o': /* offensive ones only */ >> - Offend++; >> + Offend = TRUE; >> break; >> case 's': /* short ones only */ >> - Short_only++; >> + Short_only = TRUE; >> Long_only = FALSE; >> break; >> case 'w': /* give time to read */ >> - Wait++; >> + Wait = TRUE; >> break; >> case 'm': /* dump out the fortunes */ >> - Match++; >> + Match = TRUE; >> pat = optarg; >> break; >> case 'i': /* case-insensitive match */ >>