From owner-cvs-src@FreeBSD.ORG  Tue Jan 20 02:00:10 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4056A16A4CE; Tue, 20 Jan 2004 02:00:10 -0800 (PST)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F16E143D3F; Tue, 20 Jan 2004 02:00:07 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au
	[61.8.0.86])i0KA06ug011367;	Tue, 20 Jan 2004 21:00:06 +1100
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i0KA03fe017647;	Tue, 20 Jan 2004 21:00:04 +1100
Date: Tue, 20 Jan 2004 21:00:04 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Mike Silbersack <silby@silby.com>
In-Reply-To: <20040120015009.W39477@odysseus.silby.com>
Message-ID: <20040120203319.U3819@gamplex.bde.org>
References: <200401192127.i0JLRBL3041817@repoman.freebsd.org>
	<20040120015009.W39477@odysseus.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Poul-Henning Kamp <phk@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386   
 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2004 10:00:10 -0000

On Tue, 20 Jan 2004, Mike Silbersack wrote:

> On Tue, 20 Jan 2004, Bruce Evans wrote:
>
> <much deleted>
>
> > This can be obtained by running a debugger on the panic dump.  Line
> > numbers and source file names can also be printed by the debugger
> > if the executable has at least line numbers in its debugging info.
>
> True, if you can convince the reporter to enable crashdumps and recreate
> the panic... having even roughly accurate line numbers would increase the
> usefulness of PRs quite a bit.

Just the text of the panic messages is all that you can hope for in that
case.

There are also some bugs in the details:
- the file and line are not printed in panicstr
- the file and line are printed on a separate line
- some style bugs, starting with duplicating code to print the line numbers
  in the newpanic and !newpanic cases despite the previous 2 bugs making
  the message about the line numbers being independent of newpanic.

Bruce