From owner-svn-src-all@freebsd.org Sun Jun 26 15:54:46 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03A8CB81B5F; Sun, 26 Jun 2016 15:54:46 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BD61E2D2E; Sun, 26 Jun 2016 15:54:45 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi0-x231.google.com with SMTP id r2so173003083oih.2; Sun, 26 Jun 2016 08:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NJRI5u5l8RfW7vkOuNqOA7D3bLJ/iORq9gJ/gcb2n5g=; b=JeIolOZWsEjSBrdnli7lXgnw+BLYvVWeJG2zaprGpvElz3SAHZZlr4HvttBdf/uQCW UMyJJtXRUDeD2Jd5+TGo77OGoQkpWtwxosZkJBDizZTDkm1zrKHYf9A2ban7hRFR8UlJ mEDVvx2yfklaGGm3IwhevAvywXBeyQiJuz2M3+dH02K/qmyciubmiIPOSRXvptEp1ARi Zleb/THbndnuvAFn9diU6JIqfyAclmFVq9ukqWYjL7/g8Zkxblfhk9xdOwfYMqwUep5Z cMDgIiQe06QwR8hTUa+Tr4OK978cTv9+/GvGyd+XuYBCypqWGuPldJ2BAhHysLXoxrQy RqAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NJRI5u5l8RfW7vkOuNqOA7D3bLJ/iORq9gJ/gcb2n5g=; b=JmV43JH0uZ9rH15GPampgJV2qgFFcK664WoMFJMjdy45U95kHt23omknjLXhFP1rPm cST00Cvo16n1lY+Dhc+GStzXV6qDYZ4ATE/EgnhJ3RlrOrTAShFGIIpjBSBB/UbTzTMU Mc1z8I0wcF/Fzpzs2Dd3FQdb9MEnCP8jonWVvEqmi3xSjC2Ux3IxZh/qyBiVJuRcPyD5 HEKisz+bSRT2kdO+STWmfzhot2L4cPRLteIiWdxYwhrxL03qLEUcFUzzCuIfYDKLHsDK 5Hp9fg+2pZHtABo3eLcmpv+U6Gor2h/EXci1Dk6VrRpcrhFZ8a4ZSlvnp2erF4bJdDv1 UFzA== X-Gm-Message-State: ALyK8tJdggwJwnPYsnMoNHd0PV9FcKxlR6JUHPUF6D7mPP5vD+Kpk0FT35T03w1EcvbU34wFsIzQtjnuWVtwmw== X-Received: by 10.157.22.179 with SMTP id c48mr9080352ote.35.1466956484941; Sun, 26 Jun 2016 08:54:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.12.37 with HTTP; Sun, 26 Jun 2016 08:54:44 -0700 (PDT) In-Reply-To: <201606261418.u5QEITxu002962@repo.freebsd.org> References: <201606261418.u5QEITxu002962@repo.freebsd.org> From: Benjamin Kaduk Date: Sun, 26 Jun 2016 10:54:44 -0500 Message-ID: Subject: Re: svn commit: r302210 - head/sys/fs/nfsclient To: Konstantin Belousov Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2016 15:54:46 -0000 On Sun, Jun 26, 2016 at 9:18 AM, Konstantin Belousov wrote: > Author: kib > Date: Sun Jun 26 14:18:28 2016 > New Revision: 302210 > URL: https://svnweb.freebsd.org/changeset/base/302210 > > Log: > Clean other flags in ncl_inactive, only. Add comment explaining why > other > flags should be unset. > [...] > + > + /* > + * NMODIFIED means that there might be dirty/stale buffers > + * associated with the NFS vnode. None of the other flags are > + * meaningful after the vnode is unused. > + */ > + np->n_flag &= NMODIFIED; > Maybe I am confused, but the commit message reads like this should be '=', not '&='. -Ben > + mtx_unlock(&np->n_mtx); > return (0); > } > >