Date: Sun, 26 Jun 2016 10:54:44 -0500 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Konstantin Belousov <kib@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r302210 - head/sys/fs/nfsclient Message-ID: <CAJ5_RoB%2Bz6%2BHBUd1Hzp38o1QP3uo8UNNwT319af%2B5dVGw8NSaw@mail.gmail.com> In-Reply-To: <201606261418.u5QEITxu002962@repo.freebsd.org> References: <201606261418.u5QEITxu002962@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 26, 2016 at 9:18 AM, Konstantin Belousov <kib@freebsd.org> wrote: > Author: kib > Date: Sun Jun 26 14:18:28 2016 > New Revision: 302210 > URL: https://svnweb.freebsd.org/changeset/base/302210 > > Log: > Clean other flags in ncl_inactive, only. Add comment explaining why > other > flags should be unset. > [...] > + > + /* > + * NMODIFIED means that there might be dirty/stale buffers > + * associated with the NFS vnode. None of the other flags are > + * meaningful after the vnode is unused. > + */ > + np->n_flag &= NMODIFIED; > Maybe I am confused, but the commit message reads like this should be '=', not '&='. -Ben > + mtx_unlock(&np->n_mtx); > return (0); > } > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoB%2Bz6%2BHBUd1Hzp38o1QP3uo8UNNwT319af%2B5dVGw8NSaw>