Date: Fri, 16 Aug 2024 15:45:24 +0000 From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 280564] graphics/poppler: fix build with libc++ 19 Message-ID: <bug-280564-39348-TebN5K6Bps@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-280564-39348@https.bugs.freebsd.org/bugzilla/> References: <bug-280564-39348@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280564 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D6930d099097eb9de5321e7bb9728e82= efaabf0f6 commit 6930d099097eb9de5321e7bb9728e82efaabf0f6 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-08-01 19:48:37 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-08-16 15:43:43 +0000 graphics/poppler: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes graphics/poppler to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ =20=20=20=20=20=20=20 /wrkdirs/usr/ports/graphics/poppler/work/poppler-24.02.0/cpp/poppler-global= .h:101:43: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here 101 | class POPPLER_CPP_EXPORT ustring : public std::basic_string<unsigned short> | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Upstream poppler has fixed this in commit b4ac7d9a [2], so add it as a PATCHFILES entry in the Makefile, until the next version of poppler is released. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-remov= als [2] https://gitlab.freedesktop.org/poppler/poppler/-/commit/b4ac7d9a PR: 280564 Approved by: maintainer timeout (2 weeks) MFH: 2024Q3 (cherry picked from commit 6bf6ee19368dea736b8a402d115c797f271a0f47) graphics/poppler/Makefile | 3 +++ graphics/poppler/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-280564-39348-TebN5K6Bps>